src/debug.cc - Issue 23484014: Cleanup Socket class and remove it from the platform files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug.cc

Issue 23484014: Cleanup Socket class and remove it from the platform files. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Cleanup leftover junk, and rename test-sockets to test-socket. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug.cc

diff --git a/src/debug.cc b/src/debug.cc

index 9f38601b486f28b21f430ec04cb98520268ad271..c3d737ec26e82201f035bd6b2dbada3009feb510 100644

--- a/src/debug.cc

+++ b/src/debug.cc

@@ -3433,15 +3433,11 @@ bool Debugger::StartAgent(const char* name, int port,

v8::Debug::DebugBreak();

}

- if (Socket::SetUp()) {

- if (agent_ == NULL) {

- agent_ = new DebuggerAgent(isolate_, name, port);

- agent_->Start();

- }

- return true;

+ if (agent_ == NULL) {

+ agent_ = new DebuggerAgent(isolate_, name, port);

+ agent_->Start();

}

- return false;

+ return true;

}

« no previous file with comments | « src/d8-debug.cc ('k') | src/debug-agent.h » ('j') | src/platform.h » ('J')