Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: components/certificate_transparency/log_dns_client_unittest.cc

Issue 2348393002: Minor improvements to MockLogDnsTraffic (Closed)
Patch Set: Forward declare MockSocketData Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/certificate_transparency/log_dns_client_unittest.cc
diff --git a/components/certificate_transparency/log_dns_client_unittest.cc b/components/certificate_transparency/log_dns_client_unittest.cc
index 7ec219b35f52aef94c4a4594a3fbd2a68299f2dd..f090fc8774f5c4e3da9cc4068a09221a817e6406 100644
--- a/components/certificate_transparency/log_dns_client_unittest.cc
+++ b/components/certificate_transparency/log_dns_client_unittest.cc
@@ -110,10 +110,12 @@ class MockAuditProofCallback {
int net_error_;
std::unique_ptr<net::ct::MerkleAuditProof> proof_;
base::RunLoop run_loop_;
};
+} // namespace
+
class LogDnsClientTest : public ::testing::TestWithParam<net::IoMode> {
protected:
LogDnsClientTest()
: network_change_notifier_(net::NetworkChangeNotifier::CreateMock()) {
mock_dns_.SetSocketReadMode(GetParam());
@@ -548,7 +550,6 @@ TEST_P(LogDnsClientTest, IgnoresLatestDnsConfigIfInvalid) {
INSTANTIATE_TEST_CASE_P(ReadMode,
LogDnsClientTest,
::testing::Values(net::IoMode::ASYNC,
net::IoMode::SYNCHRONOUS));
-} // namespace
} // namespace certificate_transparency

Powered by Google App Engine
This is Rietveld 408576698