Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: components/certificate_transparency/log_dns_client_unittest.cc

Issue 2348393002: Minor improvements to MockLogDnsTraffic (Closed)
Patch Set: Changes DCHECK to CHECK Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/certificate_transparency/mock_log_dns_traffic.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/certificate_transparency/log_dns_client_unittest.cc
diff --git a/components/certificate_transparency/log_dns_client_unittest.cc b/components/certificate_transparency/log_dns_client_unittest.cc
index 684eedf920898690f2aea3e623ac0b2b8d7ed102..1c5825fe2b7baf3eaa86923cdd23e903cd3594b1 100644
--- a/components/certificate_transparency/log_dns_client_unittest.cc
+++ b/components/certificate_transparency/log_dns_client_unittest.cc
@@ -113,10 +113,12 @@ class MockAuditProofCallback {
int net_error_;
std::unique_ptr<net::ct::MerkleAuditProof> proof_;
base::RunLoop run_loop_;
};
+} // namespace
+
class LogDnsClientTest : public ::testing::TestWithParam<net::IoMode> {
protected:
LogDnsClientTest()
: network_change_notifier_(net::NetworkChangeNotifier::CreateMock()) {
mock_dns_.SetSocketReadMode(GetParam());
@@ -807,7 +809,6 @@ TEST_P(LogDnsClientTest, CanBeThrottledToOneQueryAtATime) {
INSTANTIATE_TEST_CASE_P(ReadMode,
LogDnsClientTest,
::testing::Values(net::IoMode::ASYNC,
net::IoMode::SYNCHRONOUS));
-} // namespace
} // namespace certificate_transparency
« no previous file with comments | « no previous file | components/certificate_transparency/mock_log_dns_traffic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698