Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2348383004: [Extensions] Fix crash in chrome://extensions metrics (Closed)

Created:
4 years, 3 months ago by Devlin
Modified:
4 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Fix crash in chrome://extensions metrics DidStartProvisionalLoadInFrame() is apparently not guaranteed to be called before DocumentLoadedInFrame() or DocumentOnLoadCompletedInMainFrame(). Because of this, the timer was sometimes uninitialized. Handle this gracefully. BUG=647272 Committed: https://crrev.com/d6e72e27f3a4d1d008cdd16e765d3fe6de482ff4 Cr-Commit-Position: refs/heads/master@{#419629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/ui/webui/extensions/extensions_ui.cc View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Devlin
Dan, mind taking a quick look?
4 years, 3 months ago (2016-09-19 21:06:13 UTC) #2
Dan Beam
lgtm
4 years, 3 months ago (2016-09-19 21:08:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348383004/1
4 years, 3 months ago (2016-09-19 21:25:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/298982)
4 years, 3 months ago (2016-09-20 00:26:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348383004/1
4 years, 3 months ago (2016-09-20 00:31:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 01:36:24 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 01:41:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6e72e27f3a4d1d008cdd16e765d3fe6de482ff4
Cr-Commit-Position: refs/heads/master@{#419629}

Powered by Google App Engine
This is Rietveld 408576698