[wasm] Support asm.js modules with a single function.

[wasm] Support asm.js modules with a single function.

Handle the case of asm.js modules that return a single function
instead of a collection of them.

R=mtrofin@chromium.org
TEST=mjsunit/asm/asm-wasm
BUG=v8:4203
BUG=v8:5356
Committed: https://crrev.com/a4737793cb86e37eb101aa175282ffb2bda39194
Cr-Commit-Position: refs/heads/master@{#39515}

[bradnelson, 2016-09-19 18:33:52]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 18:33:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradn, 2016-09-19 18:34:22]

Description was changed from

==========
[wasm] Support asm.js modules with a single function.

Handle the case of asm.js modules that return a single function
instead of a collection of them.

R=bradnelson@chromium.org
TEST=mjsunit/asm/asm-wasm
BUG=v8:4203
BUG=v8:5356
==========

to

==========
[wasm] Support asm.js modules with a single function.

Handle the case of asm.js modules that return a single function
instead of a collection of them.

R=mtrofin@chromium.org
TEST=mjsunit/asm/asm-wasm
BUG=v8:4203
BUG=v8:5356
==========

[bradn, 2016-09-19 18:34:45]

bradnelson@google.com changed reviewers:
+ mtrofin@chromium.org
- bradnelson@chromium.org

[bradn, 2016-09-19 18:34:54]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[commit-bot: I haz the power, 2016-09-19 18:38:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 18:38:48]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Mircea Trofin, 2016-09-19 18:42:29]

LGTM w nit.

https://codereview.chromium.org/2348383003/diff/1/src/asmjs/asm-wasm-builder.cc
File src/asmjs/asm-wasm-builder.cc (right):

https://codereview.chromium.org/2348383003/diff/1/src/asmjs/asm-wasm-builder....
src/asmjs/asm-wasm-builder.cc:559: std::string raw_name = "__single_function__";
could we have these centrally defined?

[bradnelson, 2016-09-19 19:54:00]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 19:54:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 19:59:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 19:59:21]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[bradnelson, 2016-09-19 20:02:26]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 20:02:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradn, 2016-09-19 20:30:38]

https://codereview.chromium.org/2348383003/diff/1/src/asmjs/asm-wasm-builder.cc
File src/asmjs/asm-wasm-builder.cc (right):

https://codereview.chromium.org/2348383003/diff/1/src/asmjs/asm-wasm-builder....
src/asmjs/asm-wasm-builder.cc:559: std::string raw_name = "__single_function__";
On 2016/09/19 18:42:29, Mircea Trofin wrote:
> could we have these centrally defined?

Done.

[commit-bot: I haz the power, 2016-09-19 20:35:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:35:29]

Dry run: This issue passed the CQ dry run.

[bradn, 2016-09-19 20:37:05]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-09-19 20:37:06]

The patchset sent to the CQ was uploaded after l-g-t-m from mtrofin@chromium.org
Link to the patchset: https://codereview.chromium.org/2348383003/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2016-09-19 20:37:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 20:39:48]

Description was changed from

==========
[wasm] Support asm.js modules with a single function.

Handle the case of asm.js modules that return a single function
instead of a collection of them.

R=mtrofin@chromium.org
TEST=mjsunit/asm/asm-wasm
BUG=v8:4203
BUG=v8:5356
==========

to

==========
[wasm] Support asm.js modules with a single function.

Handle the case of asm.js modules that return a single function
instead of a collection of them.

R=mtrofin@chromium.org
TEST=mjsunit/asm/asm-wasm
BUG=v8:4203
BUG=v8:5356
==========

[commit-bot: I haz the power, 2016-09-19 20:39:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-19 21:01:46]

Description was changed from

==========
[wasm] Support asm.js modules with a single function.

Handle the case of asm.js modules that return a single function
instead of a collection of them.

R=mtrofin@chromium.org
TEST=mjsunit/asm/asm-wasm
BUG=v8:4203
BUG=v8:5356
==========

to

==========
[wasm] Support asm.js modules with a single function.

Handle the case of asm.js modules that return a single function
instead of a collection of them.

R=mtrofin@chromium.org
TEST=mjsunit/asm/asm-wasm
BUG=v8:4203
BUG=v8:5356

Committed: https://crrev.com/a4737793cb86e37eb101aa175282ffb2bda39194
Cr-Commit-Position: refs/heads/master@{#39515}
==========

[commit-bot: I haz the power, 2016-09-19 21:01:47]

Patchset 3 (id:??) landed as
https://crrev.com/a4737793cb86e37eb101aa175282ffb2bda39194
Cr-Commit-Position: refs/heads/master@{#39515}