Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2348373004: Internalize the ast-value-factory before tracing in trace-parse. Otherwise the string-handle isn't … (Closed)

Created:
4 years, 3 months ago by Toon Verwaest
Modified:
4 years, 3 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Internalize the ast-value-factory before tracing in trace-parse. Otherwise the string-handle isn't available yet BUG= Committed: https://crrev.com/cab644f3f26366199cbf0c7711db112aab253b2f Cr-Commit-Position: refs/heads/master@{#39536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/parsing/parser.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 3 months ago (2016-09-20 09:03:16 UTC) #2
marja
lgtm
4 years, 3 months ago (2016-09-20 09:04:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348373004/1
4 years, 3 months ago (2016-09-20 09:39:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 10:30:10 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 10:30:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cab644f3f26366199cbf0c7711db112aab253b2f
Cr-Commit-Position: refs/heads/master@{#39536}

Powered by Google App Engine
This is Rietveld 408576698