Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2348353002: First steps toward removing MethodTrampoline (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7073 lines, -5865 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 65 chunks +4364 lines, -4370 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 191 chunks +2700 lines, -1485 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 1 chunk +9 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
The only changes in the parser have been to rename methods, which caused them to ...
4 years, 3 months ago (2016-09-19 15:19:11 UTC) #2
scheglov
LGTM
4 years, 3 months ago (2016-09-19 15:23:42 UTC) #3
Brian Wilkerson
4 years, 3 months ago (2016-09-19 15:24:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
57f1193c01d9c77103356caac9b8283b8f05c0de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698