Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 234833005: Add GN build file for OpenSSL. (Closed)

Created:
6 years, 8 months ago by brettw
Modified:
6 years, 8 months ago
Reviewers:
tfarina, Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Add GN build file for OpenSSL. This sluprs in the existing .gypi file to more easily keep the builds in sync. TBR=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263283

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -2 lines) Patch
M BUILD.gn View 1 chunk +91 lines, -2 lines 4 comments Download

Messages

Total messages: 9 (0 generated)
brettw
6 years, 8 months ago (2014-04-11 17:55:58 UTC) #1
brettw
Carrying over LGTM from https://codereview.chromium.org/232563008/
6 years, 8 months ago (2014-04-11 17:57:59 UTC) #2
brettw
Committed patchset #1 manually as r263283 (presubmit successful).
6 years, 8 months ago (2014-04-11 17:58:27 UTC) #3
Ryan Sleevi
lgtm
6 years, 8 months ago (2014-04-11 17:58:56 UTC) #4
tfarina
https://codereview.chromium.org/234833005/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/234833005/diff/1/BUILD.gn#newcode22 BUILD.gn:22: # The list of OpenSSL files is kept in ...
6 years, 8 months ago (2014-04-11 18:19:36 UTC) #5
brettw
On 2014/04/11 18:19:36, tfarina wrote: > https://codereview.chromium.org/234833005/diff/1/BUILD.gn > File BUILD.gn (right): > > https://codereview.chromium.org/234833005/diff/1/BUILD.gn#newcode22 > ...
6 years, 8 months ago (2014-04-11 21:42:15 UTC) #6
tfarina
https://codereview.chromium.org/234833005/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/234833005/diff/1/BUILD.gn#newcode81 BUILD.gn:81: cflags += [ ../../third_party/openssl/openssl/crypto/ec/ec_lib.c:71:19: error: unused variable 'EC_version' [-Werror,-Wunused-const-variable] ...
6 years, 8 months ago (2014-04-12 02:40:35 UTC) #7
brettw
https://codereview.chromium.org/234833005/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/234833005/diff/1/BUILD.gn#newcode81 BUILD.gn:81: cflags += [ Which platform are you compiling on? ...
6 years, 8 months ago (2014-04-12 04:41:49 UTC) #8
tfarina
6 years, 8 months ago (2014-04-12 04:48:12 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/234833005/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/234833005/diff/1/BUILD.gn#newcode81
BUILD.gn:81: cflags += [
On 2014/04/12 04:41:49, brettw wrote:
> Which platform are you compiling on? It worked for me on Linux. 

Try building with clang, it works with gcc though. I'm building on Linux x64 as
well.

$ gn gen out/Release_gn --args="is_debug=false is_clang=true"

Powered by Google App Engine
This is Rietveld 408576698