|
|
Created:
4 years, 3 months ago by xunjieli Modified:
4 years, 3 months ago Reviewers:
Ryan Hamilton CC:
chromium-reviews, cbentzel+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse load_timing_info_test_util.cc in quic_http_stream_test.cc
This CL uses load_timing_info_test_util.cc in quic_http_stream_test.cc
so not to duplicate test logic and fixes an incorrect use of function name
camel case.
BUG=637051
Committed: https://crrev.com/84adaab847a84e634ee191d208bd8d9e9c7457d2
Cr-Commit-Position: refs/heads/master@{#419620}
Patch Set 1 #Patch Set 2 : Fix TimeTicks::Now() invocation #Messages
Total messages: 21 (14 generated)
The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
xunjieli@chromium.org changed reviewers: + rch@chromium.org
lgtm
The CQ bit was unchecked by xunjieli@chromium.org
The CQ bit was checked by xunjieli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xunjieli@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org Link to the patchset: https://codereview.chromium.org/2348313004/#ps40001 (title: "Fix TimeTicks::Now() invocation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Use load_timing_info_test_util.cc in quic_http_stream_test.cc This CL uses load_timing_info_test_util.cc in quic_http_stream_test.cc so not to duplicate test logic and fixes an incorrect use of function name camel case. BUG=637051 ========== to ========== Use load_timing_info_test_util.cc in quic_http_stream_test.cc This CL uses load_timing_info_test_util.cc in quic_http_stream_test.cc so not to duplicate test logic and fixes an incorrect use of function name camel case. BUG=637051 Committed: https://crrev.com/84adaab847a84e634ee191d208bd8d9e9c7457d2 Cr-Commit-Position: refs/heads/master@{#419620} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/84adaab847a84e634ee191d208bd8d9e9c7457d2 Cr-Commit-Position: refs/heads/master@{#419620} |