Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2348313004: Use load_timing_info_test_util.cc in quic_http_stream_test.cc (Closed)

Created:
4 years, 3 months ago by xunjieli
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use load_timing_info_test_util.cc in quic_http_stream_test.cc This CL uses load_timing_info_test_util.cc in quic_http_stream_test.cc so not to duplicate test logic and fixes an incorrect use of function name camel case. BUG=637051 Committed: https://crrev.com/84adaab847a84e634ee191d208bd8d9e9c7457d2 Cr-Commit-Position: refs/heads/master@{#419620}

Patch Set 1 #

Patch Set 2 : Fix TimeTicks::Now() invocation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -26 lines) Patch
M net/quic/chromium/quic_http_stream_test.cc View 1 7 chunks +19 lines, -26 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
xunjieli
4 years, 3 months ago (2016-09-19 21:17:22 UTC) #4
Ryan Hamilton
lgtm
4 years, 3 months ago (2016-09-19 21:21:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348313004/1
4 years, 3 months ago (2016-09-19 21:29:17 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/295718)
4 years, 3 months ago (2016-09-19 22:04:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348313004/40001
4 years, 3 months ago (2016-09-20 01:06:25 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-09-20 01:12:46 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 01:14:23 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/84adaab847a84e634ee191d208bd8d9e9c7457d2
Cr-Commit-Position: refs/heads/master@{#419620}

Powered by Google App Engine
This is Rietveld 408576698