Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2026)

Unified Diff: runtime/observatory/lib/src/elements/vm_connect.dart

Issue 2348313002: Fix VM connect element test (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/tests/observatory_ui/vm_connect/element_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/vm_connect.dart
diff --git a/runtime/observatory/lib/src/elements/vm_connect.dart b/runtime/observatory/lib/src/elements/vm_connect.dart
index 31afe384a88e8a4eb4490de896308516574b077c..49282a5e75680b921620868e4c98e5028657aa1a 100644
--- a/runtime/observatory/lib/src/elements/vm_connect.dart
+++ b/runtime/observatory/lib/src/elements/vm_connect.dart
@@ -98,7 +98,8 @@ class VMConnectElement extends HtmlElement implements Renderable {
..children = _targets.list().map((target) {
final ObservatoryApplication app =
ObservatoryApplication.app;
- final bool current = app.isConnectedVMTarget(target);
+ final bool current = (app != null) ?
+ app.isConnectedVMTarget(target) : false;
return new LIElement()
..children = [
new VMConnectTargetElement(target,
« no previous file with comments | « no previous file | runtime/observatory/tests/observatory_ui/vm_connect/element_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698