Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23483045: Revert "Switch MutationEvents UseCounter to use countDeprecation." (Closed)

Created:
7 years, 3 months ago by abarth-chromium
Modified:
7 years, 3 months ago
Reviewers:
ojan
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Revert "Switch MutationEvents UseCounter to use countDeprecation." Revert "Auto-rebaseline for r157796" This reverts commit 58d5f52f2ddf66c8dac3b9c4fa8ccfe7fb6cdb1f. This reverts commit 12abf0e5c1a4280b1177b3ea2bf2cb798492dac3. http://src.chromium.org/viewvc/blink?view=revision&revision=157796 This CL broke Telemetry. In particular, the ConsoleOutputStream test from telemetry_unittests: http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/169251/steps/telemetry_unittests/logs/testConsoleOutputStream It might have also broken Telemetry itself because the perf bots appear hosed as well. TBR=ojan Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -145 lines) Patch
M LayoutTests/editing/deleting/delete-node-after-DOMNodeRemoved-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/execCommand/5120591-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/execCommand/editing-command-while-executing-typing-command-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/execCommand/insertHTML-mutation-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/inserting/delete-insignificant-text-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/inserting/insert-html-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/inserting/insert-paragraph-separator-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/pasteboard/drag-and-drop-image-contenteditable-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/pasteboard/drag-and-drop-inputimage-contenteditable-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/pasteboard/drag-and-drop-objectimage-contenteditable-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/selection/crash-on-drag-with-mutation-events-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/style/apply-style-join-child-text-nodes-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/style/bold-with-dom-changes-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/undo/undo-after-event-edited-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Element/normalize-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLElement/set-inner-outer-optimization-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLImageElement/constructor-mutation-event-dispatch-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLSelectElement/option-add-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/added-out-of-order-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/observe-attributes-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/observe-characterdata-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/removed-out-of-order-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Node/DOMNodeRemovedEvent-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Node/fragment-mutation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/detach-range-during-deletecontents-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/range-created-in-mutation-event-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/range-delete-contents-event-fire-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/range-delete-contents-mutation-event-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/range-extractContents-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/range-insertNode-assertion-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/remove-twice-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/split-text-in-range-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/adopt-node-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/attribute-change-on-mutate-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/class-attr-change-double-mutation-fire-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/cloneNode-below-body-attribute-merging-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/containerNode-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/document-set-title-mutation-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/dom-method-document-change-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/getElementById-consistency-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/getElementById-consistency2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/getElementById-consistency3-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/getElementById-consistency4-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/getElementById-consistency5-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/insertBefore-refChild-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/insertedIntoDocument-child-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/insertedIntoDocument-sibling-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/move-nodes-across-documents-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/mutation-event-listener-with-dirty-inline-style-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/mutation-event-remove-inserted-node-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/normalize-attributes-mutation-event-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/option-text-mutation-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/remove-body-during-body-replacement-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/remove-body-during-body-replacement2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/remove-body-during-title-creation-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-boundary-crossing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/suppress-mutation-events-in-shadow-characterdata-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/suppress-mutation-events-in-shadow-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/subtree-modified-attributes-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/text-node-append-data-remove-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/xml-parser-error-message-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/attribute-listener-deletion-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/crash-on-mutate-during-drop-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/dom-character-data-modified-textarea-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/domnodeinsertedintodocument-dispatched-post-rendering-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/event-listener-moving-documents-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
A + LayoutTests/fast/events/event-listener-on-link-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/mutation-during-append-child-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/mutation-during-insert-before-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/mutation-during-replace-child-2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/mutation-during-replace-child-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/scoped/editing-commands-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/events/touch/touch-event-target-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/window-onerror-isolatedworld-02-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/add-and-remove-option-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/add-remove-option-modification-event-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/mutation-event-recalc-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/select-set-length-with-mutation-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/select-set-length-with-mutation-remove-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/select-set-length-with-mutation-reorder-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/select-set-length-with-mutation-reparent-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/textarea-and-mutation-events-appending-text-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/textarea-and-mutation-events-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/frames/iframe-onload-and-domnodeinserted-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/delete-inside-cancelTimer-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/parser/nested-fragment-parser-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/text/split-text-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/reentrant-cancel-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/media/video-controls-with-mutation-event-handler-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/mac/editing/selection/rtl-delete-within-line-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/fast/events/event-listener-on-link-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/platform/win/editing/selection/rtl-delete-within-line-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win/fast/events/event-listener-on-link-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/svg/custom/path-domsubtreemodified-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/svg/custom/tref-nested-events-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/svg/custom/use-mutation-event-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/page/UseCounter.cpp View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
7 years, 3 months ago (2013-09-16 16:24:32 UTC) #1
abarth-chromium
7 years, 3 months ago (2013-09-16 16:25:18 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r157830 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698