Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 23483035: Fast increment to the next inline renderer when the current renderer is isolated. (Closed)

Created:
7 years, 3 months ago by igoroliveira
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fast increment to the next inline renderer when the current renderer is isolated. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157181

Patch Set 1 #

Total comments: 1

Patch Set 2 : Proposed Patch V2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M Source/core/rendering/InlineIterator.h View 1 3 chunks +8 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
igoroliveira
7 years, 3 months ago (2013-09-03 22:30:32 UTC) #1
igoroliveira
7 years, 3 months ago (2013-09-03 23:20:13 UTC) #2
eseidel
Are you sure this diff is complete? https://codereview.chromium.org/23483035/diff/1/Source/core/rendering/InlineIterator.h File Source/core/rendering/InlineIterator.h (right): https://codereview.chromium.org/23483035/diff/1/Source/core/rendering/InlineIterator.h#newcode78 Source/core/rendering/InlineIterator.h:78: void fastIncrementInline(); ...
7 years, 3 months ago (2013-09-03 23:28:40 UTC) #3
igoroliveira
On 2013/09/03 23:28:40, eseidel wrote: > Are you sure this diff is complete? It is ...
7 years, 3 months ago (2013-09-03 23:34:20 UTC) #4
eseidel
lgtm
7 years, 3 months ago (2013-09-03 23:39:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/23483035/5001
7 years, 3 months ago (2013-09-03 23:40:14 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 02:14:52 UTC) #7
Message was sent while issue was closed.
Change committed as 157181

Powered by Google App Engine
This is Rietveld 408576698