[Android WebView] Wire up Blink's UseLegacyBackgroundSizeShorthandBehavior setting

android_webview/native/aw_settings.cc

Index: android_webview/native/aw_settings.cc
diff --git a/android_webview/native/aw_settings.cc b/android_webview/native/aw_settings.cc
index f47b20bfacbc5678dbc585f1796e1947858773e1..bb4c287aa0d55fa8a4ee861dd317a6a8dff97106 100644
--- a/android_webview/native/aw_settings.cc
+++ b/android_webview/native/aw_settings.cc
@@ -204,7 +204,8 @@ void AwSettings::UpdateWebkitPreferencesLocked(JNIEnv* env, jobject obj) {
       GURL(ConvertJavaStringToUTF8(url)) : GURL();
 
   prefs.support_deprecated_target_density_dpi =
-      Java_AwSettings_getSupportDeprecatedTargetDensityDPILocked(env, obj);
+      prefs.use_legacy_background_size_shorthand_behavior =
+      Java_AwSettings_getSupportLegacyQuirksLocked(env, obj);

[joth, 2013/08/28 20:07:33]

nit: the unequal indent 206 & 207 (and if more are added)  makes this hard to
scan

either rely on the defaults being false; hence:-
if (Java_AwSettings_getSupportLegacyQuirksLocked(env, obj)) {
  a = true;
  b = true;
}

or perhaps format as

bool support_quirks = Java_AwSettings_getSupportLegacyQuirksLocked(env, obj);
a = support_quirks;
b = support_quirks;

[mnaganov (inactive), 2013/08/29 11:49:25]

The latter pattern seems to be more compliant with the rest of the function, so
I've changed to it.

 
   prefs.password_echo_enabled =
       Java_AwSettings_getPasswordEchoEnabled(env, obj);