Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1696)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

Issue 23483005: [Android WebView] Wire up Blink's UseLegacyBackgroundSizeShorthandBehavior setting (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
index d82af6097a94a99b1a808193f971ab6591712a24..10acd479683f8029ddef5c5070c1329b55d2d463 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
@@ -2504,6 +2504,36 @@ public class AwSettingsTest extends AwTestBase {
}
}
+ @SmallTest
+ @Feature({"AndroidWebView", "Preferences"})
+ // background shorthand property must not override background-size when
+ // it's already set.
+ public void testUseLegacyBackgroundSizeShorthandBehavior() throws Throwable {
+ final TestAwContentsClient contentClient = new TestAwContentsClient();
+ final AwTestContainerView testContainerView =
+ createAwTestContainerViewOnMainSync(contentClient);
+ final AwContents awContents = testContainerView.getAwContents();
+ AwSettings settings = getAwSettingsOnUiThread(awContents);
+ CallbackHelper onPageFinishedHelper = contentClient.getOnPageFinishedHelper();
+ final String expectedBackgroundSize = "cover";
+ final String page = "<html><head>" +
+ "<script>" +
+ "function getBackgroundSize() {" +
+ " var e = document.getElementById('test'); " +
+ " e.style.backgroundSize = '" + expectedBackgroundSize + "';" +
+ " e.style.background = 'center red url(dummy://test.png) no-repeat border-box'; " +
+ " return e.style.backgroundSize; " +
+ "}" +
+ "</script></head>" +
+ "<body onload='document.title=getBackgroundSize()'>" +
+ " <div id='test'> </div>" +
+ "</body></html>";
+ settings.setJavaScriptEnabled(true);
+ loadDataSync(awContents, onPageFinishedHelper, page, "text/html", false);
+ String actualBackgroundSize = getTitleOnUiThread(awContents);
+ assertEquals(expectedBackgroundSize, actualBackgroundSize);
+ }
+
static class ViewPair {
private final AwContents contents0;
private final TestAwContentsClient client0;
« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwSettings.java ('k') | android_webview/native/aw_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698