Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2348293004: Disable framebuffer fetch on the Adreno5xx devices. (Closed)

Created:
4 years, 3 months ago by egdaniel
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable framebuffer fetch on the Adreno5xx devices. This should help with some of the rendering bugs currently in GL for the S7. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2348293004 Committed: https://skia.googlesource.com/skia/+/7517e45e78f1ddae86cae255d36f54732eac4f89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLUtil.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
egdaniel
4 years, 3 months ago (2016-09-20 18:54:33 UTC) #3
bsalomon
lgtm
4 years, 3 months ago (2016-09-20 19:01:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348293004/1
4 years, 3 months ago (2016-09-20 19:02:44 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 20:00:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7517e45e78f1ddae86cae255d36f54732eac4f89

Powered by Google App Engine
This is Rietveld 408576698