Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2348293003: [turbofan] Propagate tenuring decisions to child object allocations. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Propagate tenuring decisions to child object allocations. When an allocation for a parent object is pretenured, also propagate that to all allocations for objects that are (potentially) stored into the parent object. R=jarin@chromium.org Committed: https://crrev.com/825f506fab01c1e158603c0915231bd7b8ac19c8 Cr-Commit-Position: refs/heads/master@{#39534}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M src/compiler/memory-optimizer.cc View 1 chunk +31 lines, -0 lines 2 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-20 05:56:54 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the first part to Splay performance. Please take a look. Thanks, Benedikt
4 years, 3 months ago (2016-09-20 06:24:05 UTC) #6
Jarin
lgtm https://codereview.chromium.org/2348293003/diff/1/src/compiler/memory-optimizer.cc File src/compiler/memory-optimizer.cc (right): https://codereview.chromium.org/2348293003/diff/1/src/compiler/memory-optimizer.cc#newcode122 src/compiler/memory-optimizer.cc:122: OpParameter<PretenureFlag>(child) == NOT_TENURED) { Can we have PretenureFlagOf, ...
4 years, 3 months ago (2016-09-20 09:40:29 UTC) #7
Benedikt Meurer
https://codereview.chromium.org/2348293003/diff/1/src/compiler/memory-optimizer.cc File src/compiler/memory-optimizer.cc (right): https://codereview.chromium.org/2348293003/diff/1/src/compiler/memory-optimizer.cc#newcode122 src/compiler/memory-optimizer.cc:122: OpParameter<PretenureFlag>(child) == NOT_TENURED) { Follow-up CL.
4 years, 3 months ago (2016-09-20 09:42:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348293003/1
4 years, 3 months ago (2016-09-20 09:43:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 09:57:51 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 09:58:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/825f506fab01c1e158603c0915231bd7b8ac19c8
Cr-Commit-Position: refs/heads/master@{#39534}

Powered by Google App Engine
This is Rietveld 408576698