Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: pkg/analyzer_cli/lib/src/driver.dart

Issue 2348283004: Remove incremental session from analyzer_cli. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer_cli/lib/src/analyzer_impl.dart ('k') | pkg/analyzer_cli/lib/src/incremental_analyzer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_cli/lib/src/driver.dart
diff --git a/pkg/analyzer_cli/lib/src/driver.dart b/pkg/analyzer_cli/lib/src/driver.dart
index 72e5f02bcd306d00d0cc594dfb8da0648f9c696c..185290b4a7659b460e6afe8c5d26b77a489b21cb 100644
--- a/pkg/analyzer_cli/lib/src/driver.dart
+++ b/pkg/analyzer_cli/lib/src/driver.dart
@@ -38,7 +38,6 @@ import 'package:analyzer/src/task/options.dart';
import 'package:analyzer_cli/src/analyzer_impl.dart';
import 'package:analyzer_cli/src/build_mode.dart';
import 'package:analyzer_cli/src/error_formatter.dart';
-import 'package:analyzer_cli/src/incremental_analyzer.dart';
import 'package:analyzer_cli/src/options.dart';
import 'package:analyzer_cli/src/perf_report.dart';
import 'package:analyzer_cli/starter.dart';
@@ -88,8 +87,6 @@ class Driver implements CommandLineStarter {
/// creation.
CommandLineOptions _previousOptions;
- IncrementalAnalysisSession incrementalSession;
-
@override
ResolverProvider packageResolverProvider;
@@ -224,8 +221,6 @@ class Driver implements CommandLineStarter {
libUris.add(source.uri);
}
- incrementalSession?.finish();
-
// Check that each part has a corresponding source in the input list.
for (Source part in parts) {
bool found = false;
@@ -312,9 +307,6 @@ class Driver implements CommandLineStarter {
if (options.enableSuperMixins != _previousOptions.enableSuperMixins) {
return false;
}
- if (options.incrementalCachePath != _previousOptions.incrementalCachePath) {
- return false;
- }
if (!_equalLists(
options.buildSummaryInputs, _previousOptions.buildSummaryInputs)) {
return false;
@@ -537,8 +529,6 @@ class Driver implements CommandLineStarter {
_context.sourceFactory = sourceFactory;
_context.resultProvider =
new InputPackagesResultProvider(_context, summaryDataStore);
-
- incrementalSession = configureIncrementalAnalysis(options, context);
}
/// Return discovered packagespec, or `null` if none is found.
@@ -635,8 +625,8 @@ class Driver implements CommandLineStarter {
/// Analyze a single source.
ErrorSeverity _runAnalyzer(Source source, CommandLineOptions options) {
int startTime = currentTimeMillis();
- AnalyzerImpl analyzer = new AnalyzerImpl(
- _context, incrementalSession, source, options, stats, startTime);
+ AnalyzerImpl analyzer =
+ new AnalyzerImpl(_context, source, options, stats, startTime);
var errorSeverity = analyzer.analyzeSync();
if (errorSeverity == ErrorSeverity.ERROR) {
io.exitCode = errorSeverity.ordinal;
« no previous file with comments | « pkg/analyzer_cli/lib/src/analyzer_impl.dart ('k') | pkg/analyzer_cli/lib/src/incremental_analyzer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698