Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2348263005: Eliminate one copy from ImageBitmap deserialization. (Closed)

Created:
4 years, 3 months ago by jbroman
Modified:
4 years, 3 months ago
Reviewers:
haraken, xidachen
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, jbroman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate one copy from ImageBitmap deserialization. SkImage::MakeRasterCopy already does a copy, so there is no need to do another. Committed: https://crrev.com/5aa0631c59915cf473da41e7a15eadbd5108ff76 Cr-Commit-Position: refs/heads/master@{#419923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jbroman
Didn't want to add an extra copy while implementing the same in the new V8ScriptValueSerializer, ...
4 years, 3 months ago (2016-09-20 22:12:33 UTC) #4
haraken
LGTM
4 years, 3 months ago (2016-09-20 23:54:39 UTC) #5
xidachen
lgtm
4 years, 3 months ago (2016-09-21 00:05:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348263005/1
4 years, 3 months ago (2016-09-21 00:29:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 00:45:10 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 00:46:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5aa0631c59915cf473da41e7a15eadbd5108ff76
Cr-Commit-Position: refs/heads/master@{#419923}

Powered by Google App Engine
This is Rietveld 408576698