Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2348203003: Fix navigations after HTML5 history push losing their SSL status. (Closed)

Created:
4 years, 3 months ago by jam
Modified:
4 years, 3 months ago
Reviewers:
estark
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix navigations after HTML5 history push losing their SSL status. BUG=647683 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/9edf16001930c58297ae6790c74c5b36050906e8 Cr-Commit-Position: refs/heads/master@{#419633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jam
4 years, 3 months ago (2016-09-19 22:32:17 UTC) #3
estark
lgtm, thank you!
4 years, 3 months ago (2016-09-20 00:31:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348203003/1
4 years, 3 months ago (2016-09-20 00:33:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 01:41:45 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 01:43:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9edf16001930c58297ae6790c74c5b36050906e8
Cr-Commit-Position: refs/heads/master@{#419633}

Powered by Google App Engine
This is Rietveld 408576698