Issue 23482005: Add background page to good2.crx

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23482005: Add background page to good2.crx (Closed)

Created:
7 years, 3 months ago by bartfab (slow)

Modified:
7 years, 3 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, anitawoodruff

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add background page to good2.crx This CL adds a background page to the good2.crx extension used in tests. This is part of CL 23427003 but had to be committed separately because the CQ cannot handle binary file changes. BUG=175701 TEST=None TBR=kalman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220551

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, --1 lines)			Patch
	M	chrome/test/data/extensions/good2.crx	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

bartfab (slow)

7 years, 3 months ago (2013-08-30 11:19:29 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r220551 (presubmit successful).

Expand Messages | Collapse Messages