ui/views/controls/textfield/textfield_model.cc - Issue 2348143003: MacViews: Implement Force Touch/Mac dictionary lookup for Textfields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/textfield_model.cc

Issue 2348143003: MacViews: Implement Force Touch/Mac dictionary lookup for Textfields. (Closed)

Patch Set: Address nits. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/textfield/textfield_model.cc

diff --git a/ui/views/controls/textfield/textfield_model.cc b/ui/views/controls/textfield/textfield_model.cc

index a89c3cc99aa9ae0d48a321b85faef35ef54e74a0..dc1bc5539ef39a35a37a72714a9ad13923daf36a 100644

--- a/ui/views/controls/textfield/textfield_model.cc

+++ b/ui/views/controls/textfield/textfield_model.cc

@@ -624,9 +624,7 @@ void TextfieldModel::DeleteSelectionAndInsertTextAt(

}

base::string16 TextfieldModel::GetTextFromRange(const gfx::Range& range) const {

- if (range.IsValid() && range.GetMin() < text().length())

- return text().substr(range.GetMin(), range.length());

- return base::string16();

+ return render_text_->GetTextFromRange(range);

}

void TextfieldModel::GetTextRange(gfx::Range* range) const {

« no previous file with comments | « ui/views/controls/textfield/textfield.cc ('k') | ui/views/view.h » ('j') | no next file with comments »