Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/views/controls/textfield/textfield_model.h

Issue 2348143003: MacViews: Implement Force Touch/Mac dictionary lookup for Textfields. (Closed)
Patch Set: Fix compile. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/gfx/render_text_unittest.cc ('K') | « ui/views/controls/textfield/textfield.cc ('k') | ui/views/controls/textfield/textfield_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/textfield/textfield_model.h
diff --git a/ui/views/controls/textfield/textfield_model.h b/ui/views/controls/textfield/textfield_model.h
index c66fe6d068083ee7047790207da919042160e663..cfc18afe75476a57349fbb9bded71cfc3153394c 100644
--- a/ui/views/controls/textfield/textfield_model.h
+++ b/ui/views/controls/textfield/textfield_model.h
@@ -205,7 +205,9 @@ class VIEWS_EXPORT TextfieldModel {
size_t position);
// Retrieves the text content in a given range.
- base::string16 GetTextFromRange(const gfx::Range& range) const;
+ base::string16 GetTextFromRange(const gfx::Range& range) const {
+ return render_text_->GetTextFromRange(range);
msw 2016/10/04 01:52:37 nit: I think this still belongs in the .cc file
karandeepb 2016/10/04 12:04:25 Done.
+ }
// Retrieves the range containing all text in the model.
void GetTextRange(gfx::Range* range) const;
« ui/gfx/render_text_unittest.cc ('K') | « ui/views/controls/textfield/textfield.cc ('k') | ui/views/controls/textfield/textfield_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698