Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3463)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/gfx/render_text_mac.mm

Issue 2348143003: MacViews: Implement Force Touch/Mac dictionary lookup for Textfields. (Closed)
Patch Set: Fix compile. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/gfx/render_text_harfbuzz.cc ('K') | « ui/gfx/render_text_mac.h ('k') | ui/gfx/render_text_unittest.cc » ('j') | ui/gfx/render_text_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_mac.mm
diff --git a/ui/gfx/render_text_mac.mm b/ui/gfx/render_text_mac.mm
index e380333c8c88f471ac158b6c5f30bfc043d3d371..14852046df0173e44f81c6fa335dc78a0a9adec2 100644
--- a/ui/gfx/render_text_mac.mm
+++ b/ui/gfx/render_text_mac.mm
@@ -448,4 +448,17 @@
runs_valid_ = false;
}
+bool RenderTextMac::GetDecoratedTextForRange(
+ const Range& range,
+ DecoratedText* decorated_text) const {
+ // TODO(karandeepb): This is not invoked on any codepath currently. Style the
+ // returned text if need be.
+ if (obscured())
+ return false;
+
+ decorated_text->attributes.clear();
msw 2016/10/04 01:52:37 q: is this necessary?
karandeepb 2016/10/04 12:04:24 Not really, removed.
+ decorated_text->text = GetTextFromRange(range);
+ return true;
+}
+
} // namespace gfx
« ui/gfx/render_text_harfbuzz.cc ('K') | « ui/gfx/render_text_mac.h ('k') | ui/gfx/render_text_unittest.cc » ('j') | ui/gfx/render_text_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698