MacViews: Implement Force Touch/Mac dictionary lookup for Textfields.

ui/views/cocoa/bridged_content_view.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_content_view.h"
 
 #include "base/logging.h"
 #import "base/mac/mac_util.h"
 #import "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
 #include "skia/ext/skia_utils_mac.h"
 #include "ui/base/cocoa/cocoa_base_utils.h"
 #include "ui/base/dragdrop/drag_drop_types.h"
 #include "ui/base/dragdrop/os_exchange_data_provider_mac.h"
 #include "ui/base/ime/input_method.h"
 #include "ui/base/ime/text_edit_commands.h"
 #include "ui/base/ime/text_input_client.h"
 #include "ui/compositor/canvas_painter.h"
 #import "ui/events/cocoa/cocoa_event_utils.h"
+#include "ui/events/event_utils.h"
 #include "ui/events/keycodes/dom/dom_code.h"
 #import "ui/events/keycodes/keyboard_code_conversion_mac.h"
 #include "ui/gfx/canvas_paint_mac.h"
 #include "ui/gfx/geometry/rect.h"
 #import "ui/gfx/mac/coordinate_conversion.h"
 #include "ui/gfx/path.h"
 #import "ui/gfx/path_mac.h"
 #include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h"
 #import "ui/views/cocoa/bridged_native_widget.h"
 #import "ui/views/cocoa/drag_drop_client_mac.h"
@@ skipping 703 matching lines @@
 }
 
 - (void)scrollWheel:(NSEvent*)theEvent {
   if (!hostedView_)
     return;
 
   ui::MouseWheelEvent event(theEvent);
   hostedView_->GetWidget()->OnMouseEvent(&event);
 }
 
+- (void)quickLookWithEvent:(NSEvent*)theEvent {
+  if (!hostedView_)
+    return;
+
+  const gfx::Point& locationInContent = ui::EventLocationFromNative(theEvent);

[tapted, 2016/09/21 04:06:56]

no reference (I know C++ allows this to extend the lifetime of an rvalue, but it
doesn't get used much in chrome)

[karandeepb, 2016/09/22 08:17:39]

Done. 

+  views::View* target = hostedView_->GetEventHandlerForPoint(locationInContent);
+  if (!target)
+    return;
+
+  gfx::Point locationInTarget = locationInContent;
+  // Todo check if ConvertPointToTarget is safe.
+  views::View::ConvertPointToTarget(hostedView_, target, &locationInTarget);
+  NSMutableAttributedString* word =

[tapted, 2016/09/21 04:06:56]

Use scoped_nsobject - autorelease has additional overheads

[karandeepb, 2016/09/22 08:17:39]

I guess it's preferred to return an autoreleased NSAttributedString from
GetAttributedString() rather than a scoped_nsobject?

+      [[[NSMutableAttributedString alloc] init] autorelease];
+  gfx::Point baselinePoint;
+  bool retreived =
+      target->GetWordAtPoint(locationInTarget, word, &baselinePoint);

[tapted, 2016/09/21 04:06:56]

If there's an existing selection, does quickLook look that up instead of just
the word?

[tapted, 2016/09/21 04:44:14]

Ah, I checked this, and it doesn't :). But you can look up a selection via the
context menu - we need to anticipate support for this later on.

[karandeepb, 2016/09/21 05:37:12]

Yeah I had thought about that. The private RenderText::GetStyledStringForRange
method could be used for it later on.

+  if (!retreived)
+    return;
+
+  // Convert |baselinePoint| to coordinate system of |hostedView_|.
+  views::View::ConvertPointToTarget(target, hostedView_, &baselinePoint);
+  NSPoint baselinePointAppKit = NSMakePoint(
+      baselinePoint.x(), NSHeight([self frame]) - baselinePoint.y());
+  [self showDefinitionForAttributedString:word atPoint:baselinePointAppKit];
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // NSResponder Action Messages. Keep sorted according NSResponder.h (from the
 // 10.9 SDK). The list should eventually be complete. Anything not defined will
 // beep when interpretKeyEvents: would otherwise call it.
 // TODO(tapted): Make this list complete, except for insert* methods which are
 // dispatched as regular key events in doCommandBySelector:.
 
 // views::Textfields are single-line only, map Paragraph and Document commands
 // to Line. Also, Up/Down commands correspond to beginning/end of line.
 
@@ skipping 603 matching lines @@
   }
 
   return [super accessibilityAttributeValue:attribute];
 }
 
 - (id)accessibilityHitTest:(NSPoint)point {
   return [hostedView_->GetNativeViewAccessible() accessibilityHitTest:point];
 }
 
 @end