MacViews: Implement Force Touch/Mac dictionary lookup for Textfields.

ui/gfx/render_text.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_RENDER_TEXT_H_
 #define UI_GFX_RENDER_TEXT_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 479 matching lines @@
   // Rect can't have a negative width.)
   virtual Range GetGlyphBounds(size_t index) = 0;
 
   const Vector2d& GetUpdatedDisplayOffset();
   void SetDisplayOffset(int horizontal_offset);
 
   // Returns the line offset from the origin after applying the text alignment
   // and the display offset.
   Vector2d GetLineOffset(size_t line_number);
 
+  // Retreives the |word| displayed at the given |point|. |point| is in the
+  // view's coordinates. If no word is displayed at the point, returns a nearby
+  // word. |baseline_point| should correspond to the left baseline point of the
+  // leftmost glyph of the |word| in the view's coordinates. Returns false, if
+  // no word can be retreived.
+  bool GetWordAtPoint(const Point& point,
+                      NativeStyledString word,
+                      Point* baseline_point);
+
+  // Retreives the text in the given |range|.
+  base::string16 GetTextFromRange(Range range) const;
+
  protected:
   RenderText();
 
   // NOTE: The value of these accessors may be stale. Please make sure
   // that these fields are up to date before accessing them.
   const base::string16& layout_text() const { return layout_text_; }
   const base::string16& display_text() const { return display_text_; }
   bool text_elided() const { return text_elided_; }
 
   const BreakList<SkColor>& colors() const { return colors_; }
@@ skipping 196 matching lines @@
   // Elides |email| as needed to fit the |available_width|.
   base::string16 ElideEmail(const base::string16& email, float available_width);
 
   // Update the cached bounds and display offset to ensure that the current
   // cursor is within the visible display area.
   void UpdateCachedBoundsAndOffset();
 
   // Draw the selection.
   void DrawSelection(Canvas* canvas);
 
+  // Returns the nearest word start boundary for |index|. First searches in
+  // CURSOR_BACKWARD direction, then in CURSOR_FORWARD direction. Returns
+  // text length if no valid boundary is found.
+  size_t GetNearestWordStartBoundary(size_t index) const;
+
+  // Expands |range| to it's nearest word boundaries and returns the resulting

[tapted, 2016/09/21 04:06:55]

nit: it's -> its

[karandeepb, 2016/09/22 08:17:39]

Done.

+  // range. Maintains directionality of |range|.
+  Range ExpandRangeToWordBoundary(const Range& range) const;
+
+  // Returns the styled string corresponding to |range|. Returns false if the
+  // string cannot be retreived, e.g. if the text is obscured.
+  virtual bool GetStyledStringForRange(const Range& range,

[tapted, 2016/09/21 04:06:55]

this should be in protected: - private virtuals don't really make sense

[karandeepb, 2016/09/22 08:17:39]

Shouldn't private virtual functions be preferred, when the function does not
need access to the base class implementation? Also as a general rule, shouldn't
we try to tighten the access specifiers as much as possible?

+                                       NativeStyledString str) const = 0;
+
   // Logical UTF-16 string data to be drawn.
   base::string16 text_;
 
   // Horizontal alignment of the text with respect to |display_rect_|.  The
   // default is to align left if the application UI is LTR and right if RTL.
   HorizontalAlignment horizontal_alignment_;
 
   // The text directionality mode, defaults to DIRECTIONALITY_FROM_TEXT.
   DirectionalityMode directionality_mode_;
 
@@ skipping 124 matching lines @@
   // Lines computed by EnsureLayout. These should be invalidated upon
   // OnLayoutTextAttributeChanged and OnDisplayTextAttributeChanged calls.
   std::vector<internal::Line> lines_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderText);
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_RENDER_TEXT_H_