Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2957)

Unified Diff: base/native_library_posix.cc

Issue 2348143002: Check if RTLD_DEEPBIND is defined before using it. (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/native_library_posix.cc
diff --git a/base/native_library_posix.cc b/base/native_library_posix.cc
index 786333e65ae147648309ffb82aaf506616d690c9..3459716af1c68d550fe246b70d3d70979a736efd 100644
--- a/base/native_library_posix.cc
+++ b/base/native_library_posix.cc
@@ -30,10 +30,10 @@ NativeLibrary LoadNativeLibraryWithOptions(const FilePath& library_path,
// http://crbug.com/17943, http://crbug.com/17557, http://crbug.com/36892,
// and http://crbug.com/40794.
int flags = RTLD_LAZY;
-#if defined(OS_ANDROID)
- // Android dlopen() requires further investigation, as it might vary across
- // versions. Crash here to warn developers that they're trying to rely on
- // uncertain behavior.
+#if defined(OS_ANDROID) || !defined(RTLD_DEEPBIND)
+ // Certain platforms don't define RTLD_DEEPBIND. Android dlopen() requires
+ // further investigation, as it might vary across versions. Crash here to
+ // warn developers that they're trying to rely on uncertain behavior.
CHECK(!options.prefer_own_symbols);
#else
if (options.prefer_own_symbols)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698