Check if RTLD_DEEPBIND is defined before using it.

Check if RTLD_DEEPBIND is defined before using it.

uClibc does not support RTLD_DEEPBIND, and thus it is not defined in
dlfcn.h. Check if this flag is defined before using it in
native_library_posix.cc to support uClibc-based builds.

BUG= internal b/31575857

Committed: https://crrev.com/76e9f56c7be25a6c5f16548be2e475734858f6d0
Cr-Commit-Position: refs/heads/master@{#422491}

[slan, 2016-09-18 19:51:41]

slan@chromium.org changed reviewers:
+ rockot@chromium.org

[slan, 2016-09-18 19:51:42]

Hey Ken, this is needed for an internal Cast bot which uses uClibc on MIPS.
PTAL!

[slan, 2016-09-18 19:54:21]

slan@chromium.org changed reviewers:
+ thakis@chromium.org

[slan, 2016-09-18 19:54:22]

+Nico for OWNERS

[Nico, 2016-09-19 15:17:18]

I'll defer to rockot who added this. I don't know if it's better to crash if
this is set and we can't honor it, like we do on android.

[Ken Rockot(use gerrit already), 2016-09-19 17:38:30]

On 2016/09/19 at 15:17:18, thakis wrote:
> I'll defer to rockot who added this. I don't know if it's better to crash if
this is set and we can't honor it, like we do on android.

Yeah, how about changing defined(OS_ANDROID) to  defined(OS_ANDROID) ||
!defined(RTLD_DEEPBIND) and making a note in the comment that some platforms
don't define it.

[slan, 2016-10-03 18:15:58]

On 2016/09/19 17:38:30, Ken Rockot wrote:
> On 2016/09/19 at 15:17:18, thakis wrote:
> > I'll defer to rockot who added this. I don't know if it's better to crash if
> this is set and we can't honor it, like we do on android.
> 
> Yeah, how about changing defined(OS_ANDROID) to  defined(OS_ANDROID) ||
> !defined(RTLD_DEEPBIND) and making a note in the comment that some platforms
> don't define it.

Done in PS2. PTAL!

[Ken Rockot(use gerrit already), 2016-10-03 18:19:56]

LGTM, thanks!

[slan, 2016-10-03 18:28:48]

The CQ bit was checked by slan@chromium.org

[commit-bot: I haz the power, 2016-10-03 18:29:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 18:40:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 18:40:32]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2016-10-03 19:01:18]

lgtm too

[Nico, 2016-10-03 19:01:22]

The CQ bit was checked by thakis@chromium.org

[slan, 2016-10-03 19:01:47]

The CQ bit was unchecked by slan@chromium.org

[slan, 2016-10-03 19:01:47]

The CQ bit was checked by slan@chromium.org

[commit-bot: I haz the power, 2016-10-03 19:02:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 19:30:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-03 19:32:18]

Description was changed from

==========
Check if RTLD_DEEPBIND is defined before using it.

uClibc does not support RTLD_DEEPBIND, and thus it is not defined in
dlfcn.h. Check if this flag is defined before using it in
native_library_posix.cc to support uClibc-based builds.

BUG= internal b/31575857
==========

to

==========
Check if RTLD_DEEPBIND is defined before using it.

uClibc does not support RTLD_DEEPBIND, and thus it is not defined in
dlfcn.h. Check if this flag is defined before using it in
native_library_posix.cc to support uClibc-based builds.

BUG= internal b/31575857

Committed: https://crrev.com/76e9f56c7be25a6c5f16548be2e475734858f6d0
Cr-Commit-Position: refs/heads/master@{#422491}
==========

[commit-bot: I haz the power, 2016-10-03 19:32:19]

Patchset 2 (id:??) landed as
https://crrev.com/76e9f56c7be25a6c5f16548be2e475734858f6d0
Cr-Commit-Position: refs/heads/master@{#422491}