Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 234813010: Remove oilevent from tough layout cases. (Closed)

Created:
6 years, 8 months ago by tonyg
Modified:
6 years, 8 months ago
Reviewers:
RyanS, shatch
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

Remove oilevent from tough layout cases. It OOMs on some android devices now and no one has the cycles to debug. BUG=357326 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266039

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/perf/page_sets/tough_layout_cases.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tonyg
6 years, 8 months ago (2014-04-12 00:37:38 UTC) #1
shatch
lgtm
6 years, 8 months ago (2014-04-24 21:03:57 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 8 months ago (2014-04-24 21:04:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/234813010/1
6 years, 8 months ago (2014-04-24 21:14:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 21:14:26 UTC) #5
commit-bot: I haz the power
Failed to apply patch for tools/perf/page_sets/tough_layout_cases.json: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
6 years, 8 months ago (2014-04-24 21:14:26 UTC) #6
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 8 months ago (2014-04-24 21:31:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/234813010/20001
6 years, 8 months ago (2014-04-24 22:00:18 UTC) #8
commit-bot: I haz the power
Change committed as 266039
6 years, 8 months ago (2014-04-24 23:24:36 UTC) #9
tonyg
6 years, 8 months ago (2014-04-25 20:52:12 UTC) #10
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/252703005/ by tonyg@chromium.org.

The reason for reverting is: Did not fix OOM, just moved it.

BUG=357326.

Powered by Google App Engine
This is Rietveld 408576698