Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 23481011: Send Android accessibility "content changed" event for any change. (Closed)

Created:
7 years, 3 months ago by dmazzoni
Modified:
7 years, 3 months ago
Reviewers:
joth, benm (inactive)
CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, jam, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Send Android accessibility "content changed" event for any change. Specifically, AccessibilityEvent.TYPE_WINDOW_CONTENT_CHANGED should be fired on the appropriate node any time the accessibility tree changes - previously we were only firing it in a few circumstances. That guarantees tools like uiautomatorviewer won't see a stale accessibility tree. BUG=286374 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221853

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_android.cc View 2 chunks +6 lines, -3 lines 2 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dmazzoni
7 years, 3 months ago (2013-09-06 17:24:28 UTC) #1
joth
lgtm assuming it works :-) https://codereview.chromium.org/23481011/diff/1/content/browser/accessibility/browser_accessibility_manager_android.cc File content/browser/accessibility/browser_accessibility_manager_android.cc (right): https://codereview.chromium.org/23481011/diff/1/content/browser/accessibility/browser_accessibility_manager_android.cc#newcode97 content/browser/accessibility/browser_accessibility_manager_android.cc:97: env, obj.obj(), node->renderer_id()); to ...
7 years, 3 months ago (2013-09-06 18:50:21 UTC) #2
dmazzoni
Yes, I tested it and this definitely fixes the issue with uiautomatorviewer! https://codereview.chromium.org/23481011/diff/1/content/browser/accessibility/browser_accessibility_manager_android.cc File content/browser/accessibility/browser_accessibility_manager_android.cc ...
7 years, 3 months ago (2013-09-06 19:33:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/23481011/1
7 years, 3 months ago (2013-09-06 19:35:02 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 01:40:44 UTC) #5
Message was sent while issue was closed.
Change committed as 221853

Powered by Google App Engine
This is Rietveld 408576698