Include JSONParser options into its fuzzer.

Include JSONParser options into its fuzzer.

Also drop creation and destruction of the JSONReader object because the fuzzed
method is static anyways.

BUG=none

Committed: https://crrev.com/d79a3a25470080ac70e74dbbcea5fb618be441fa
Cr-Commit-Position: refs/heads/master@{#421153}

[Thiemo Nagel, 2016-09-17 11:52:05]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 11:52:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Thiemo Nagel, 2016-09-17 11:52:53]

Description was changed from

==========
Include JSONParser options into its fuzzer.

Also drop creation and destruction of the JSONReader object because the fuzzed
function is static anyways.

BUG=none
==========

to

==========
Include JSONParser options into its fuzzer.

Also drop creation and destruction of the JSONReader object because the fuzzed
method is static anyways.

BUG=none
==========

[Thiemo Nagel, 2016-09-17 11:53:22]

tnagel@chromium.org changed reviewers:
+ mmoroz@chromium.org

[Thiemo Nagel, 2016-09-17 11:53:23]

Hi Max,

could you please take a look?

Thank you!
Thiemo

[commit-bot: I haz the power, 2016-09-17 12:30:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 12:30:48]

Dry run: This issue passed the CQ dry run.

[inferno, 2016-09-17 14:29:09]

inferno@chromium.org changed reviewers:
+ inferno@chromium.org

[inferno, 2016-09-17 14:29:10]

lgtm

might be better to even hook into JSONReader::ReadAndReturnError ? That parses
some more fields in memory.

if (!root) {
    if (error_code_out)
      *error_code_out = parser.error_code();
    if (error_msg_out)
      *error_msg_out = parser.GetErrorMessage();
    if (error_line_out)
      *error_line_out = parser.error_line();
    if (error_column_out)
      *error_column_out = parser.error_column();
  }

[mmoroz, 2016-09-17 16:41:38]

LGTM for the improvement to fuzz |options|, thanks for adding this!

and +1 to call ReadAndReturnError
(https://cs.chromium.org/chromium/src/base/json/json_reader.cc?sq=package:chro...),
thanks inferno@ for the suggestion.

[Thiemo Nagel, 2016-09-26 16:18:12]

inferno, could you please take another look?

Thank you,
Thiemo

[inferno, 2016-09-27 08:47:37]

lgtm

[Thiemo Nagel, 2016-09-27 08:52:20]

On 2016/09/27 08:47:37, inferno wrote:
> lgtm

Thank you!

[Thiemo Nagel, 2016-09-27 08:52:24]

The CQ bit was checked by tnagel@chromium.org

[Thiemo Nagel, 2016-09-27 08:52:24]

The patchset sent to the CQ was uploaded after l-g-t-m from mmoroz@chromium.org
Link to the patchset: https://codereview.chromium.org/2348053002/#ps60001
(title: "Move stack variables to the heap.")

[commit-bot: I haz the power, 2016-09-27 08:52:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 09:03:16]

Description was changed from

==========
Include JSONParser options into its fuzzer.

Also drop creation and destruction of the JSONReader object because the fuzzed
method is static anyways.

BUG=none
==========

to

==========
Include JSONParser options into its fuzzer.

Also drop creation and destruction of the JSONReader object because the fuzzed
method is static anyways.

BUG=none
==========

[commit-bot: I haz the power, 2016-09-27 09:03:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-27 09:05:29]

Description was changed from

==========
Include JSONParser options into its fuzzer.

Also drop creation and destruction of the JSONReader object because the fuzzed
method is static anyways.

BUG=none
==========

to

==========
Include JSONParser options into its fuzzer.

Also drop creation and destruction of the JSONReader object because the fuzzed
method is static anyways.

BUG=none

Committed: https://crrev.com/d79a3a25470080ac70e74dbbcea5fb618be441fa
Cr-Commit-Position: refs/heads/master@{#421153}
==========

[commit-bot: I haz the power, 2016-09-27 09:05:30]

Patchset 4 (id:??) landed as
https://crrev.com/d79a3a25470080ac70e74dbbcea5fb618be441fa
Cr-Commit-Position: refs/heads/master@{#421153}