Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 234803004: Wrap isActivatedSubmit() in WebFormControlElement (Closed)

Created:
6 years, 8 months ago by ziran.sun
Modified:
6 years, 8 months ago
Reviewers:
tkent, Garrett Casto
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Wrap isActivatedSubmit() in WebFormControlElement This is related refactoring old Blink code, specifically moving functions in WebPasswordFormData and WebPasswordFormUtils into chromium side. Inevitably, HTMLFormControlElement.isActivatedSubmit() that is called in WebPasswordFormData needs to be exposed to chromium side. R=gcasto@chromium.org, tkent@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171571

Patch Set 1 #

Patch Set 2 : Remove IsActivatedsumbit() in webInputElement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M Source/web/WebFormControlElement.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/web/WebInputElement.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebFormControlElement.h View 1 chunk +3 lines, -0 lines 0 comments Download
M public/web/WebInputElement.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Garrett Casto
I don't think that this is necessary. This data is already exposed via WebInputElement::isActivatedSubmit().
6 years, 8 months ago (2014-04-11 20:26:53 UTC) #1
ziran.sun
On 2014/04/11 20:26:53, Garrett Casto wrote: > I don't think that this is necessary. This ...
6 years, 8 months ago (2014-04-14 10:10:58 UTC) #2
tkent
Yeah, <button type=submit> can be an activated-submit button. We should remove WebInputElement::isActivatedSubmit in this CL.
6 years, 8 months ago (2014-04-14 23:08:06 UTC) #3
Garrett Casto
On 2014/04/14 23:08:06, tkent wrote: > Yeah, <button type=submit> can be an activated-submit button. > ...
6 years, 8 months ago (2014-04-14 23:24:03 UTC) #4
ziran.sun
Updated code as per discussions. Please review. Thanks!
6 years, 8 months ago (2014-04-15 12:35:04 UTC) #5
tkent
lgtm
6 years, 8 months ago (2014-04-15 12:59:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/234803004/20001
6 years, 8 months ago (2014-04-15 12:59:38 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 14:06:12 UTC) #8
Message was sent while issue was closed.
Change committed as 171571

Powered by Google App Engine
This is Rietveld 408576698