Issue 23480102: Merged r16566, r16471 into 3.20 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23480102: Merged r16566, r16471 into 3.20 branch. (Closed)

Created:
7 years, 3 months ago by Yang

Modified:
7 years, 3 months ago

Reviewers:
ulan, Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.20

Visibility:
Public.

Merged r16566, r16471 into 3.20 branch. Fix polymorphic INTERCEPTOR StoreICs on ARM/MIPS Representation of interceptor / handler properties are tagged. Otherwise store ICs will never be initialized, due to lookup->CanHoldValue(value); BUG=chromium:284998, chromium:256330 R=verwaest@chromium.org, ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16884

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -5 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/property.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r16884.