base/process/launch_win.cc - Issue 23480061: GTTF: launch test processes using job objects on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process/launch_win.cc

Issue 23480061: GTTF: launch test processes using job objects on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/process/launch_win.cc

diff --git a/base/process/launch_win.cc b/base/process/launch_win.cc

index c5126c56fb8577f4e65f04f2b69df935dde884b1..da913efba749089592644c627c2dc226dbfa6182 100644

--- a/base/process/launch_win.cc

+++ b/base/process/launch_win.cc

@@ -195,10 +195,9 @@ bool LaunchProcess(const CommandLine& cmdline,

return LaunchProcess(cmdline.GetCommandLineString(), options, process_handle);

}

-bool SetJobObjectAsKillOnJobClose(HANDLE job_object) {

+bool SetJobObjectLimitFlags(HANDLE job_object, DWORD limit_flags) {

JOBOBJECT_EXTENDED_LIMIT_INFORMATION limit_info = {0};

- limit_info.BasicLimitInformation.LimitFlags =

- JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE;

+ limit_info.BasicLimitInformation.LimitFlags = limit_flags;

return 0 != SetInformationJobObject(

job_object,

JobObjectExtendedLimitInformation,

« no previous file with comments | « base/process/launch.h ('k') | base/test/test_launcher.cc » ('j') | no next file with comments »