Correctly stringify mixed encoding indirect strings.

test/cctest/test-strings.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 999 matching lines @@
     "          (non_ascii[j] + external_non_ascii[i - j])) return 12;"
     "    }"
     "  }"
     "  return 0;"
     "};"
     "test()";
   CHECK_EQ(0, CompileRun(source)->Int32Value());
 }
 
 
+TEST(JSONStringifySliceMadeExternal) {
+  Isolate* isolate = Isolate::Current();
+  Zone zone(isolate);
+  CcTest::InitializeVM();
+
+  // Create a sliced string from a two-byte string.  The latter is turned
+  // into a one-byte external string.  Check that JSON.stringify works.
+  { v8::HandleScope handle_scope(CcTest::isolate());
+    v8::Handle<v8::String> underlying =
+        CompileRun("var underlying = '\u2603bcdefghijklmnopqrstuvwxyz';"
+                   "underlying")->ToString();
+    v8::Handle<v8::String> slice =
+        CompileRun("var slice = underlying.slice(1);"
+                   "slice")->ToString();
+    CHECK(v8::Utils::OpenHandle(*slice)->IsSlicedString());
+    CHECK(v8::Utils::OpenHandle(*underlying)->IsSeqTwoByteString());
+
+    int length = underlying->Length();
+    uint8_t* one_byte = zone.NewArray<uint8_t>(length + 1);
+    underlying->WriteOneByte(one_byte);
+    AsciiResource* resource =
+        new(&zone) AsciiResource(Vector<const char>(
+            reinterpret_cast<char*>(one_byte), length));
+    CHECK(underlying->MakeExternal(resource));
+    CHECK(v8::Utils::OpenHandle(*slice)->IsSlicedString());
+    CHECK(v8::Utils::OpenHandle(*underlying)->IsExternalAsciiString());
+
+    CHECK_EQ("\"bcdefghijklmnopqrstuvwxyz\"",
+             *v8::String::Utf8Value(CompileRun("JSON.stringify(slice)")));
+  }
+
+  // Create a sliced string from a one-byte string.  The latter is turned
+  // into a two-byte external string.  Check that JSON.stringify works.
+  { v8::HandleScope handle_scope(CcTest::isolate());
+    v8::Handle<v8::String> underlying =
+        CompileRun("var underlying = 'abcdefghijklmnopqrstuvwxyz';"
+                   "underlying")->ToString();
+    v8::Handle<v8::String> slice =
+        CompileRun("var slice = underlying.slice(1);"
+                   "slice")->ToString();
+    CHECK(v8::Utils::OpenHandle(*slice)->IsSlicedString());
+    CHECK(v8::Utils::OpenHandle(*underlying)->IsSeqOneByteString());
+
+    int length = underlying->Length();
+    uc16* two_byte = zone.NewArray<uc16>(length + 1);
+    underlying->Write(two_byte);
+    Resource* resource =
+        new(&zone) Resource(Vector<const uc16>(two_byte, length));
+    CHECK(underlying->MakeExternal(resource));
+    CHECK(v8::Utils::OpenHandle(*slice)->IsSlicedString());
+    CHECK(v8::Utils::OpenHandle(*underlying)->IsExternalTwoByteString());
+
+    CHECK_EQ("\"bcdefghijklmnopqrstuvwxyz\"",
+             *v8::String::Utf8Value(CompileRun("JSON.stringify(slice)")));
+  }
+}
+
+
 TEST(CachedHashOverflow) {
   // We incorrectly allowed strings to be tagged as array indices even if their
   // values didn't fit in the hash field.
   // See http://code.google.com/p/v8/issues/detail?id=728
   Isolate* isolate = Isolate::Current();
   Zone zone(isolate);
 
   CcTest::InitializeVM();
   v8::HandleScope handle_scope(CcTest::isolate());
   // Lines must be executed sequentially. Combining them into one script
@@ skipping 319 matching lines @@
       CheckCanonicalEquivalence(c, test);
       continue;
     }
     if (upper != c && lower != c) {
       CheckCanonicalEquivalence(c, test);
       continue;
     }
     CHECK_EQ(Min(upper, lower), test);
   }
 }