Source/core/platform/Scrollbar.cpp - Issue 23480037: Fix RTL scroll bars being misrendered on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/Scrollbar.cpp

Issue 23480037: Fix RTL scroll bars being misrendered on Android. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: isLeftSideVerticalScrollbar Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/platform/Scrollbar.cpp

diff --git a/Source/core/platform/Scrollbar.cpp b/Source/core/platform/Scrollbar.cpp

index c48e510cfcdbb9cab6a020bb7f485d23168d00d7..db35415dde50ed51957a15c824938d111dc79aa6 100644

--- a/Source/core/platform/Scrollbar.cpp

+++ b/Source/core/platform/Scrollbar.cpp

@@ -121,11 +121,11 @@ bool Scrollbar::isScrollViewScrollbar() const

return parent() && parent()->isFrameView() && toFrameView(parent())->isScrollViewScrollbar(this);

}

-TextDirection Scrollbar::textDirection() const

+bool Scrollbar::isLeftSideVerticalScrollbar() const

{

if (m_orientation == VerticalScrollbar && m_scrollableArea)

- return m_scrollableArea->textDirection();

- return LTR;

+ return m_scrollableArea->shouldPlaceVerticalScrollbarOnLeft();

+ return false;

}

void Scrollbar::offsetDidChange()