media/base/android/java/src/org/chromium/media/MediaCodecBridge.java - Issue 23480036: Support creating secure decoder in MediaCodecBridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/java/src/org/chromium/media/MediaCodecBridge.java

Issue 23480036: Support creating secure decoder in MediaCodecBridge. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/android_video_decode_accelerator.cc ('k') | media/base/android/java/src/org/chromium/media/MediaDrmBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/java/src/org/chromium/media/MediaCodecBridge.java

diff --git a/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java b/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java

index 7025a1de6f19aa14461866e6d101bcf69827908f..918c191fa0da5bcd6bb48a31b5c060fbc4ce2afd 100644

--- a/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java

+++ b/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java

@@ -141,7 +141,8 @@ class MediaCodecBridge {

private static MediaCodecBridge create(String mime, boolean isSecure) {

MediaCodec mediaCodec = null;

try {

- if (isSecure) {

+ // |isSecure| only applies to video decoders.

+ if (mime.startsWith("video") && isSecure) {

mediaCodec = MediaCodec.createByCodecName(getSecureDecoderNameForMime(mime));

} else {

mediaCodec = MediaCodec.createDecoderByType(mime);