src/x64/full-codegen-x64.cc - Issue 23480031: Enable preaging of code objects when --optimize-for-size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 23480031: Enable preaging of code objects when --optimize-for-size. (Closed) Base URL: https://v8.googlecode.com/svn/trunk

Patch Set: Make pre-aging conditional on is_memory_constrained() Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index c182dd0ce5800d8db1247fcdf9d4490c0881e6ca..3d9354a8f22daf3f6e2cd362ca43a67206208896 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -155,7 +155,15 @@ void FullCodeGenerator::Generate() {

info->set_prologue_offset(masm_->pc_offset());

__ push(rbp); // Caller's frame pointer.

__ movq(rbp, rsp);

- __ push(rsi); // Callee's context.

+ if (isolate()->is_memory_constrained()) {

+ // This sequence marks pre-aged code.

+ __ push(rsi); // Callee's context.

+ __ nop();

+ } else {

+ // This sequence marks non-aged code.

+ __ nop();

+ __ push(rsi); // Callee's context

+ }

__ push(rdi); // Callee's JS Function.

info->AddNoFrameRange(0, masm_->pc_offset());