src/mips/lithium-codegen-mips.cc - Issue 23480031: Enable preaging of code objects when --optimize-for-size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/lithium-codegen-mips.cc

Issue 23480031: Enable preaging of code objects when --optimize-for-size. (Closed) Base URL: https://v8.googlecode.com/svn/trunk

Patch Set: Make pre-aging conditional on is_memory_constrained() Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips/lithium-codegen-mips.cc

diff --git a/src/mips/lithium-codegen-mips.cc b/src/mips/lithium-codegen-mips.cc

index ab713a3cec4a06d74e6c4e3edf1980eae0789283..b538df89d49938a5915a11482c32e48df4012c05 100644

--- a/src/mips/lithium-codegen-mips.cc

+++ b/src/mips/lithium-codegen-mips.cc

@@ -162,7 +162,9 @@ bool LCodeGen::GeneratePrologue() {

__ Push(ra, fp, cp, a1);

// Add unused nop to ensure prologue sequence is identical for

// full-codegen and lithium-codegen.

- __ nop(Assembler::CODE_AGE_SEQUENCE_NOP);

+ __ nop(isolate()->is_memory_constrained() ?

+ Assembler::CODE_AGE_PRE_AGED_SEQUENCE_NOP :

+ Assembler::CODE_AGE_YOUNG_SEQUENCE_NOP);

// Adj. FP to point to saved FP.

__ Addu(fp, sp, Operand(2 * kPointerSize));

}