src/arm/full-codegen-arm.cc - Issue 23480031: Enable preaging of code objects when --optimize-for-size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/full-codegen-arm.cc

Issue 23480031: Enable preaging of code objects when --optimize-for-size. (Closed) Base URL: https://v8.googlecode.com/svn/trunk

Patch Set: Make pre-aging conditional on is_memory_constrained() Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/full-codegen-arm.cc

diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc

index 28ec1a2a9a823415ab13f920a6e5c20363ba96b1..baeb0cce7b16e85085637957633c4d9c4595c378 100644

--- a/src/arm/full-codegen-arm.cc

+++ b/src/arm/full-codegen-arm.cc

@@ -169,7 +169,9 @@ void FullCodeGenerator::Generate() {

// The following three instructions must remain together and unmodified

// for code aging to work properly.

__ stm(db_w, sp, r1.bit() | cp.bit() | fp.bit() | lr.bit());

- __ nop(ip.code());

+ // Pre-age code objects on memory constrained devices.

+ __ nop(isolate()->is_memory_constrained() ?

+ kPreAgeCodeNopType : kNoAgeCodeNopType);

// Adjust FP to point to saved FP.

__ add(fp, sp, Operand(2 * kPointerSize));

}