Enable preaging of code objects when --optimize-for-size.

src/ia32/codegen-ia32.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1110 matching lines @@
   __ pshufd(input, input, static_cast<uint8_t>(0xe1));  // Order: 11 10 00 01
   __ movdbl(double_scratch, Operand::StaticArray(
       temp2, times_8, ExternalReference::math_exp_log_table()));
   __ por(input, double_scratch);
   __ mulsd(result, input);
   __ bind(&done);
 }
 
 #undef __
 
-static const int kNoCodeAgeSequenceLength = 5;
+static const int kCodeAgeSequenceLength = 6;
 
 static byte* GetNoCodeAgeSequence(uint32_t* length) {
   static bool initialized = false;
-  static byte sequence[kNoCodeAgeSequenceLength];
-  *length = kNoCodeAgeSequenceLength;
+  static byte sequence[kCodeAgeSequenceLength];
+  *length = kCodeAgeSequenceLength;
   if (!initialized) {
     // The sequence of instructions that is patched out for aging code is the
     // following boilerplate stack-building prologue that is found both in
     // FUNCTION and OPTIMIZED_FUNCTION code:
-    CodePatcher patcher(sequence, kNoCodeAgeSequenceLength);
+    CodePatcher patcher(sequence, kCodeAgeSequenceLength);
     patcher.masm()->push(ebp);
     patcher.masm()->mov(ebp, esp);
     patcher.masm()->push(esi);
     patcher.masm()->push(edi);
+    patcher.masm()->nop();

[rmcilroy, 2013/09/11 15:28:28]

If you have any ideas for how to distingish between pre-aged and young code
sequences without adding this nop on x86/64, that would be awesome.

     initialized = true;
   }
   return sequence;
+}
+
+
+static byte* GetPreAgedCodeAgeSequence(uint32_t* length) {
+  static bool initialized = false;
+  static byte sequence[kCodeAgeSequenceLength];
+  *length = kCodeAgeSequenceLength;
+  if (!initialized) {
+    // If code is "pre-aged" then this sequence of instructions is found in the
+    // boilerplate stack-building prologue that is found in FUNCTIONS and
+    // OPTIMIZED_FUNCTION code, and is patched out for code aging.
+    CodePatcher patcher(sequence, kCodeAgeSequenceLength);
+    patcher.masm()->push(ebp);
+    patcher.masm()->mov(ebp, esp);
+    patcher.masm()->push(esi);
+    patcher.masm()->nop();
+    patcher.masm()->push(edi);
+    initialized = true;
+  }
+  return sequence;
 }
 
 
 bool Code::IsYoungSequence(byte* sequence) {
   uint32_t young_length;
   byte* young_sequence = GetNoCodeAgeSequence(&young_length);
   bool result = (!memcmp(sequence, young_sequence, young_length));
-  ASSERT(result || *sequence == kCallOpcode);
+  ASSERT(result || *sequence == kCallOpcode || IsPreAgedSequence(sequence));
   return result;
 }
 
+
+bool Code::IsPreAgedSequence(byte* sequence) {
+  uint32_t pre_aged_length;
+  byte* pre_aged_sequence = GetPreAgedCodeAgeSequence(&pre_aged_length);
+  bool result = (!memcmp(sequence, pre_aged_sequence, pre_aged_length));
+  ASSERT(result || *sequence == kCallOpcode || IsYoungSequence(sequence));
+  return result;
+}
+
 
 void Code::GetCodeAgeAndParity(byte* sequence, Age* age,
                                MarkingParity* parity) {
   if (IsYoungSequence(sequence)) {
     *age = kNoAge;
     *parity = NO_MARKING_PARITY;
+  } else if (IsPreAgedSequence(sequence)) {
+    *age = kPreAgedCodeAge;
+    *parity = NO_MARKING_PARITY;
   } else {
     sequence++;  // Skip the kCallOpcode byte
     Address target_address = sequence + *reinterpret_cast<int*>(sequence) +
         Assembler::kCallTargetAddressOffset;
     Code* stub = GetCodeFromTargetAddress(target_address);
     GetCodeAgeAndParity(stub, age, parity);
   }
 }
 
 
 void Code::PatchPlatformCodeAge(byte* sequence,
                                 Code::Age age,
                                 MarkingParity parity) {
   uint32_t young_length;
   byte* young_sequence = GetNoCodeAgeSequence(&young_length);
   if (age == kNoAge) {
     CopyBytes(sequence, young_sequence, young_length);
     CPU::FlushICache(sequence, young_length);
   } else {
     Code* stub = GetCodeAgeStub(age, parity);
     CodePatcher patcher(sequence, young_length);
     patcher.masm()->call(stub->instruction_start(), RelocInfo::NONE32);
+    patcher.masm()->nop();
   }
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32