Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: media/audio/audio_manager_base.cc

Issue 23480030: Output device enumeration for Alsa, plus unit test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mediaPulseaudio
Patch Set: Merge to parent, match use_alsa logic. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/audio/audio_manager_base.h" 5 #include "media/audio/audio_manager_base.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/message_loop/message_loop_proxy.h" 10 #include "base/message_loop/message_loop_proxy.h"
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 void AudioManagerBase::ShowAudioInputSettings() { 308 void AudioManagerBase::ShowAudioInputSettings() {
309 } 309 }
310 310
311 void AudioManagerBase::GetAudioInputDeviceNames( 311 void AudioManagerBase::GetAudioInputDeviceNames(
312 AudioDeviceNames* device_names) { 312 AudioDeviceNames* device_names) {
313 } 313 }
314 314
315 void AudioManagerBase::GetAudioOutputDeviceNames( 315 void AudioManagerBase::GetAudioOutputDeviceNames(
316 AudioDeviceNames* device_names) { 316 AudioDeviceNames* device_names) {
317 // TODO(joi): Remove this and keep pure virtual once implemented everywhere. 317 // TODO(joi): Remove this and keep pure virtual once implemented everywhere.
318 NOTIMPLEMENTED(); 318 NOTREACHED() << "Don't use this yet, it's not ready on all platforms!";
319 } 319 }
320 320
321 void AudioManagerBase::ReleaseOutputStream(AudioOutputStream* stream) { 321 void AudioManagerBase::ReleaseOutputStream(AudioOutputStream* stream) {
322 DCHECK(stream); 322 DCHECK(stream);
323 // TODO(xians) : Have a clearer destruction path for the AudioOutputStream. 323 // TODO(xians) : Have a clearer destruction path for the AudioOutputStream.
324 // For example, pass the ownership to AudioManager so it can delete the 324 // For example, pass the ownership to AudioManager so it can delete the
325 // streams. 325 // streams.
326 --num_output_streams_; 326 --num_output_streams_;
327 delete stream; 327 delete stream;
328 } 328 }
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
426 NOTIMPLEMENTED(); 426 NOTIMPLEMENTED();
427 return ""; 427 return "";
428 } 428 }
429 429
430 std::string AudioManagerBase::GetDefaultOutputDeviceID() { 430 std::string AudioManagerBase::GetDefaultOutputDeviceID() {
431 NOTIMPLEMENTED(); 431 NOTIMPLEMENTED();
432 return ""; 432 return "";
433 } 433 }
434 434
435 } // namespace media 435 } // namespace media
OLDNEW
« no previous file with comments | « no previous file | media/audio/audio_manager_unittest.cc » ('j') | media/audio/audio_manager_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698