Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 23480021: Introduce toSVGFESpecularLightingElement(), and use it (Closed)

Created:
7 years, 3 months ago by gyuyoung-inactive
Modified:
7 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, pdr, eae+blinkwatch, Stephen Chennney, f(malita), dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce toSVGFESpecularLightingElement(), and use it As a step to clean-up static_cast<SVGXXX>, toSVGFESpecularLightingElement() is added to clean-up static_cast<SVGFESpecularLightingElement*>. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M Source/core/svg/SVGFELightElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGFESpecularLightingElement.h View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gyuyoung-inactive
Add tkent to reviewer.
7 years, 3 months ago (2013-08-30 05:56:56 UTC) #1
tkent
lgtm
7 years, 3 months ago (2013-08-30 05:59:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23480021/1
7 years, 3 months ago (2013-08-30 05:59:55 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 06:46:19 UTC) #4
Message was sent while issue was closed.
Change committed as 156963

Powered by Google App Engine
This is Rietveld 408576698