src/x64/deoptimizer-x64.cc - Issue 23480013: Turn interrupt and stack check into builtins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/deoptimizer-x64.cc

Issue 23480013: Turn interrupt and stack check into builtins. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/deoptimizer-x64.cc

diff --git a/src/x64/deoptimizer-x64.cc b/src/x64/deoptimizer-x64.cc

index 33d4f4dd585ec1ae64503434785606250ce64a70..9e1f5a5f0951c3d2719618db7414935daff3effe 100644

--- a/src/x64/deoptimizer-x64.cc

+++ b/src/x64/deoptimizer-x64.cc

@@ -151,10 +151,9 @@ Deoptimizer::InterruptPatchState Deoptimizer::GetInterruptPatchState(

return PATCHED_FOR_OSR;

} else {

// Get the interrupt stub code object to match against from cache.

- Code* interrupt_code = NULL;

- InterruptStub stub;

- if (!stub.FindCodeInCache(&interrupt_code, isolate)) UNREACHABLE();

- ASSERT_EQ(interrupt_code->entry(),

+ Code* interrupt_bulitin =

Jakob Kummerow 2013/08/30 10:42:32 nit: typo

+ isolate->builtins()->builtin(Builtins::kInterruptCheck);

+ ASSERT_EQ(interrupt_bulitin->entry(),

Assembler::target_address_at(call_target_address));

ASSERT_EQ(kJnsInstruction, *(call_target_address - 3));

ASSERT_EQ(kJnsOffset, *(call_target_address - 2));

« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »