Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 23480013: Turn interrupt and stack check into builtins. (Closed)

Created:
7 years, 3 months ago by Yang
Modified:
7 years, 3 months ago
Reviewers:
titzer, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Turn interrupt and stack check into builtins. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16444

Patch Set 1 #

Total comments: 1

Patch Set 2 : mips port, fix typo #

Patch Set 3 : fix mips #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -120 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/builtins.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 chunk +0 lines, -24 lines 0 comments Download
M src/deoptimizer.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 3 chunks +5 lines, -7 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
7 years, 3 months ago (2013-08-29 15:44:19 UTC) #1
Jakob Kummerow
LGTM, but you'll have to do the MIPS port so we can include this in ...
7 years, 3 months ago (2013-08-30 10:42:32 UTC) #2
Jakob Kummerow
lgtm
7 years, 3 months ago (2013-08-30 10:50:55 UTC) #3
Yang
7 years, 3 months ago (2013-08-30 11:25:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r16444.

Powered by Google App Engine
This is Rietveld 408576698