runtime/vm/object.h - Issue 23480005: Change Bool::Get to return a handle instead of a pointer to a raw object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.h

Issue 23480005: Change Bool::Get to return a handle instead of a pointer to a raw object. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.h

diff --git a/runtime/vm/object.h b/runtime/vm/object.h

index 3ecc8e1556b136da8689d841fa05f292573bd18a..79cd9649f3552be4aba2c3157a33548c6d79794f 100644

--- a/runtime/vm/object.h

+++ b/runtime/vm/object.h

@@ -5101,8 +5101,8 @@ class Bool : public Instance {

return Object::bool_false();

}

- static RawBool* Get(bool value) {

- return value ? Bool::True().raw() : Bool::False().raw();

+ static const Bool& Get(bool value) {

+ return value ? Bool::True() : Bool::False();

}

srdjan 2013/08/27 15:32:44 Best from both worlds? add: static RawBool* GetRaw

Ivan Posva 2013/08/27 15:51:25 I would think that is overkill.

private:

« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »