runtime/vm/dart_api_impl.cc - Issue 23480005: Change Bool::Get to return a handle instead of a pointer to a raw object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 23480005: Change Bool::Get to return a handle instead of a pointer to a raw object. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index b55b5b290e6c2a37729823d723da32a86250b030..3e23ce47aa248c7559352737f05927a6050b4505 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -3821,7 +3821,7 @@ DART_EXPORT void Dart_SetWeakHandleReturnValue(Dart_NativeArguments args,

DART_EXPORT void Dart_SetBooleanReturnValue(Dart_NativeArguments args,

bool retval) {

NativeArguments* arguments = reinterpret_cast<NativeArguments*>(args);

- arguments->SetReturn(retval ? Bool::True() : Bool::False());

+ arguments->SetReturn(Bool::Get(retval));

}

« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | runtime/vm/object.h » ('J')