Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: runtime/lib/identical.cc

Issue 23480005: Change Bool::Get to return a handle instead of a pointer to a raw object. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/bootstrap_natives.h" 5 #include "vm/bootstrap_natives.h"
6 6
7 #include "vm/object.h" 7 #include "vm/object.h"
8 8
9 namespace dart { 9 namespace dart {
10 10
11 DEFINE_NATIVE_ENTRY(Identical_comparison, 2) { 11 DEFINE_NATIVE_ENTRY(Identical_comparison, 2) {
12 GET_NATIVE_ARGUMENT(Instance, a, arguments->NativeArgAt(0)); 12 GET_NATIVE_ARGUMENT(Instance, a, arguments->NativeArgAt(0));
13 GET_NATIVE_ARGUMENT(Instance, b, arguments->NativeArgAt(1)); 13 GET_NATIVE_ARGUMENT(Instance, b, arguments->NativeArgAt(1));
14 if (a.raw() == b.raw()) return Bool::True().raw(); 14 if (a.raw() == b.raw()) return Bool::True().raw();
15 if (a.IsInteger() && b.IsInteger()) { 15 if (a.IsInteger() && b.IsInteger()) {
16 return Bool::Get(a.Equals(b)); 16 return Bool::Get(a.Equals(b)).raw();
17 } 17 }
18 if (a.IsDouble() && b.IsDouble()) { 18 if (a.IsDouble() && b.IsDouble()) {
19 if (a.Equals(b)) return Bool::True().raw(); 19 if (a.Equals(b)) return Bool::True().raw();
20 // Check for NaN. 20 // Check for NaN.
21 const Double& a_double = Double::Cast(a); 21 const Double& a_double = Double::Cast(a);
22 const Double& b_double = Double::Cast(b); 22 const Double& b_double = Double::Cast(b);
23 if (isnan(a_double.value()) && isnan(b_double.value())) { 23 if (isnan(a_double.value()) && isnan(b_double.value())) {
24 return Bool::True().raw(); 24 return Bool::True().raw();
25 } 25 }
26 } 26 }
27 return Bool::False().raw(); 27 return Bool::False().raw();
28 } 28 }
29 29
30 30
31 } // namespace dart 31 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/lib/double.cc ('k') | runtime/lib/integers.cc » ('j') | runtime/vm/object.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698