Clean up CPDF_Stream.

Clean up CPDF_Stream.

Replace the CPDF_Stream(nullptr, 0, nullptr) pattern with
a default ctor.

Remove unused parameters from CPDF_Stream::SetData(). Both
are always passed as FALSE.

CPDF_Stream declared its own m_GenNum, which shadowed the one
in CPDF_Object. It was used only to distinguish file/memory
streams, so add a bool explicitly for this purpose.

Remove the union, it would be sad if we confused user data
with a C++ object with virtual function calls.

Use unique_ptrs with appropriate deleters to manage memory.

Committed: https://pdfium.googlesource.com/pdfium/+/e6db16e7e6cdc3dd213c16de0d792b77656ac7a6

[Tom Sepez, 2016-09-16 22:04:34]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 22:04:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-16 22:06:57]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-09-16 22:06:58]

Dan, for review.

[commit-bot: I haz the power, 2016-09-16 22:15:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 22:15:12]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-09-16 22:55:33]

Description was changed from

==========
Remove unused parameters from CPDF_Stream::SetData()

Both are always passed as FALSE.
==========

to

==========
Clean up CPDF_Stream.

Remove unused parameters from CPDF_Stream::SetData(). Both
are always passed as FALSE.

CPDF_Stream declared its own m_GenNum, which shadowed the one
in CPDF_Object. It only used it to distinguish file/memory
streams, so add a bool explicitly for this purpose.

Remove the union, it would be sad if we confused user data
with a C++ object with virtual function calls.

Use unique_ptrs with appropriate deleters to manage memory.
==========

[Tom Sepez, 2016-09-16 22:56:09]

Description was changed from

==========
Clean up CPDF_Stream.

Remove unused parameters from CPDF_Stream::SetData(). Both
are always passed as FALSE.

CPDF_Stream declared its own m_GenNum, which shadowed the one
in CPDF_Object. It only used it to distinguish file/memory
streams, so add a bool explicitly for this purpose.

Remove the union, it would be sad if we confused user data
with a C++ object with virtual function calls.

Use unique_ptrs with appropriate deleters to manage memory.
==========

to

==========
Clean up CPDF_Stream.

Remove unused parameters from CPDF_Stream::SetData(). Both
are always passed as FALSE.

CPDF_Stream declared its own m_GenNum, which shadowed the one
in CPDF_Object. It was used only to distinguish file/memory
streams, so add a bool explicitly for this purpose.

Remove the union, it would be sad if we confused user data
with a C++ object with virtual function calls.

Use unique_ptrs with appropriate deleters to manage memory.
==========

[Tom Sepez, 2016-09-16 23:00:25]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 23:00:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 23:14:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 23:14:13]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-09-16 23:22:52]

Description was changed from

==========
Clean up CPDF_Stream.

Remove unused parameters from CPDF_Stream::SetData(). Both
are always passed as FALSE.

CPDF_Stream declared its own m_GenNum, which shadowed the one
in CPDF_Object. It was used only to distinguish file/memory
streams, so add a bool explicitly for this purpose.

Remove the union, it would be sad if we confused user data
with a C++ object with virtual function calls.

Use unique_ptrs with appropriate deleters to manage memory.
==========

to

==========
Clean up CPDF_Stream.

Replace the CPDF_Stream(nullptr, 0, nullptr) pattern with
a default ctor.

Remove unused parameters from CPDF_Stream::SetData(). Both
are always passed as FALSE.

CPDF_Stream declared its own m_GenNum, which shadowed the one
in CPDF_Object. It was used only to distinguish file/memory
streams, so add a bool explicitly for this purpose.

Remove the union, it would be sad if we confused user data
with a C++ object with virtual function calls.

Use unique_ptrs with appropriate deleters to manage memory.
==========

[Tom Sepez, 2016-09-16 23:23:57]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 23:24:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 23:37:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 23:37:26]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-09-19 13:12:19]

lgtm w/ nit

https://codereview.chromium.org/2347993002/diff/40001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/include/cpdf_stream.h (right):

https://codereview.chromium.org/2347993002/diff/40001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/include/cpdf_stream.h:22: CPDF_Stream(uint8_t* pData,
uint32_t size, CPDF_Dictionary* pDict);
Can we pass through a std::unique_ptr to make the ownership transfer explicit?
Maybe as a followup?

[Tom Sepez, 2016-09-19 16:49:17]

On 2016/09/19 13:12:19, dsinclair wrote:
> lgtm w/ nit
> 
>
https://codereview.chromium.org/2347993002/diff/40001/core/fpdfapi/fpdf_parse...
> File core/fpdfapi/fpdf_parser/include/cpdf_stream.h (right):
> 
>
https://codereview.chromium.org/2347993002/diff/40001/core/fpdfapi/fpdf_parse...
> core/fpdfapi/fpdf_parser/include/cpdf_stream.h:22: CPDF_Stream(uint8_t* pData,
> uint32_t size, CPDF_Dictionary* pDict);
> Can we pass through a std::unique_ptr to make the ownership transfer explicit?
> Maybe as a followup?

Ok, follow up.

[Tom Sepez, 2016-09-19 16:49:21]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-09-19 16:49:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 17:45:11]

Description was changed from

==========
Clean up CPDF_Stream.

Replace the CPDF_Stream(nullptr, 0, nullptr) pattern with
a default ctor.

Remove unused parameters from CPDF_Stream::SetData(). Both
are always passed as FALSE.

CPDF_Stream declared its own m_GenNum, which shadowed the one
in CPDF_Object. It was used only to distinguish file/memory
streams, so add a bool explicitly for this purpose.

Remove the union, it would be sad if we confused user data
with a C++ object with virtual function calls.

Use unique_ptrs with appropriate deleters to manage memory.
==========

to

==========
Clean up CPDF_Stream.

Replace the CPDF_Stream(nullptr, 0, nullptr) pattern with
a default ctor.

Remove unused parameters from CPDF_Stream::SetData(). Both
are always passed as FALSE.

CPDF_Stream declared its own m_GenNum, which shadowed the one
in CPDF_Object. It was used only to distinguish file/memory
streams, so add a bool explicitly for this purpose.

Remove the union, it would be sad if we confused user data
with a C++ object with virtual function calls.

Use unique_ptrs with appropriate deleters to manage memory.

Committed:
https://pdfium.googlesource.com/pdfium/+/e6db16e7e6cdc3dd213c16de0d792b77656a...
==========

[commit-bot: I haz the power, 2016-09-19 17:45:12]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/e6db16e7e6cdc3dd213c16de0d792b77656a...