chrome/browser/ui/webui/settings/search_engines_handler.cc - Issue 2347973002: Enable Chrome to tweak search engines for some locales

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/search_engines_handler.cc

Issue 2347973002: Enable Chrome to tweak search engines for some locales (Closed)

Patch Set: final nits Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/settings/search_engines_handler.cc

diff --git a/chrome/browser/ui/webui/settings/search_engines_handler.cc b/chrome/browser/ui/webui/settings/search_engines_handler.cc

index 467007da91f2e68113447f89b6e7c5349f88b315..5a41c09f7a89e7d8264db4d882e1498df3113597 100644

--- a/chrome/browser/ui/webui/settings/search_engines_handler.cc

+++ b/chrome/browser/ui/webui/settings/search_engines_handler.cc

@@ -184,7 +184,7 @@ SearchEnginesHandler::CreateDictionaryForEngine(int index, bool is_default) {

list_controller_.CanMakeDefault(template_url));

dict->SetBoolean("default", is_default);

dict->SetBoolean("canBeEdited", list_controller_.CanEdit(template_url));

- TemplateURL::Type type = template_url->GetType();

+ TemplateURL::Type type = template_url->type();

dict->SetBoolean("isOmniboxExtension",

type == TemplateURL::OMNIBOX_API_EXTENSION);

if (type == TemplateURL::NORMAL_CONTROLLED_BY_EXTENSION ||