Enable Chrome to tweak search engines for some locales

components/search_engines/template_url.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_H_
 #define COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_H_
 
 #include <stddef.h>
 
 #include <memory>
@@ skipping 480 matching lines @@
 // is made a friend so that it can be the exception to this pattern.
 class TemplateURL {
  public:
   enum Type {
     // Regular search engine.
     NORMAL,
     // Installed by extension through Override Settings API.
     NORMAL_CONTROLLED_BY_EXTENSION,
     // The keyword associated with an extension that uses the Omnibox API.
     OMNIBOX_API_EXTENSION,
+    // Installed only on this device. Should not be synced.
+    LOCAL,
   };
 
   // An AssociatedExtensionInfo represents information about the extension that
   // added the search engine.
   struct AssociatedExtensionInfo {
-    AssociatedExtensionInfo(Type type, const std::string& extension_id);
+    AssociatedExtensionInfo(const std::string& extension_id);

[Peter Kasting, 2016/09/21 21:45:08]

Nit: explicit

[Ian Wen, 2016/09/21 23:12:38]

Done.

     ~AssociatedExtensionInfo();
 
-    Type type;
-
     std::string extension_id;
 
     // Whether the search engine is supposed to be default.
     bool wants_to_be_default_engine;
 
     // Used to resolve conflicts when there are multiple extensions specifying
     // the default search engine. The most recently-installed wins.
     base::Time install_time;
   };
 
-  explicit TemplateURL(const TemplateURLData& data);
+  TemplateURL(const TemplateURLData& data, Type type = NORMAL);

[Peter Kasting, 2016/09/21 21:45:08]

Nit: I think this still needs "explicit"?  Or does the compiler not allow an
implicit conversion of TemplateURLData to TemplateURL with this declaration?

[Ian Wen, 2016/09/21 23:12:38]

Compiler allows it. Yet I agree explicit should be here.

[Peter Kasting, 2016/09/23 01:28:36]

What I meant was, if the compiler allows it, we definitely need it, because we
don't want to allow it :)  Anyway, I think we're good now.

   ~TemplateURL();
 
   // Generates a suitable keyword for the specified url, which must be valid.
   // This is guaranteed not to return an empty string, since TemplateURLs should
   // never have an empty keyword.
   static base::string16 GenerateKeyword(const GURL& url);
 
   // Generates a favicon URL from the specified url.
   static GURL GenerateFaviconURL(const GURL& url);
 
@@ skipping 73 matching lines @@
   const TemplateURLRef& suggestions_url_ref() const {
     return suggestions_url_ref_;
   }
   const TemplateURLRef& instant_url_ref() const { return instant_url_ref_; }
   const TemplateURLRef& image_url_ref() const { return image_url_ref_; }
   const TemplateURLRef& new_tab_url_ref() const { return new_tab_url_ref_; }
   const TemplateURLRef& contextual_search_url_ref() const {
     return contextual_search_url_ref_;
   }
 
+  Type type() const { return type_; }
+  void set_type(Type type) { type_ = type; }
+
   // This setter shouldn't be used except by TemplateURLService and
   // TemplateURLServiceClient implementations.
   void set_extension_info(
       std::unique_ptr<AssociatedExtensionInfo> extension_info) {
     extension_info_ = std::move(extension_info);
   }
 
   // Returns true if |url| supports replacement.
   bool SupportsReplacement(const SearchTermsData& search_terms_data) const;
 
   // Returns true if any URLRefs use Googe base URLs.
   bool HasGoogleBaseURLs(const SearchTermsData& search_terms_data) const;
 
   // Returns true if this TemplateURL uses Google base URLs and has a keyword
   // of "google.TLD".  We use this to decide whether we can automatically
   // update the keyword to reflect the current Google base URL TLD.
   bool IsGoogleSearchURLWithReplaceableKeyword(
       const SearchTermsData& search_terms_data) const;
 
   // Returns true if the keywords match or if
   // IsGoogleSearchURLWithReplaceableKeyword() is true for both |this| and
   // |other|.
   bool HasSameKeywordAs(const TemplateURLData& other,
                         const SearchTermsData& search_terms_data) const;
 
-  Type GetType() const;
-
   // Returns the id of the extension that added this search engine. Only call
   // this for TemplateURLs of type NORMAL_CONTROLLED_BY_EXTENSION or
   // OMNIBOX_API_EXTENSION.
   std::string GetExtensionId() const;
 
   // Returns the type of this search engine, or SEARCH_ENGINE_OTHER if no
   // engines match.
   SearchEngineType GetEngineType(
       const SearchTermsData& search_terms_data) const;
 
@@ skipping 98 matching lines @@
   TemplateURLRef suggestions_url_ref_;
   TemplateURLRef instant_url_ref_;
   TemplateURLRef image_url_ref_;
   TemplateURLRef new_tab_url_ref_;
   TemplateURLRef contextual_search_url_ref_;
   std::unique_ptr<AssociatedExtensionInfo> extension_info_;
 
   // Caches the computed engine type across successive calls to GetEngineType().
   mutable SearchEngineType engine_type_;
 
+  Type type_;

[Peter Kasting, 2016/09/21 21:45:08]

Nit: I'd probably place this above |engine_type_|.

[Ian Wen, 2016/09/21 23:12:38]

Done.

+
   // TODO(sky): Add date last parsed OSD file.
 
   DISALLOW_COPY_AND_ASSIGN(TemplateURL);
 };
 
 #endif  // COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_H_